331154 - Folder title doesn't update in UI when set using nsINavBookmarkService::setFolderTitle()

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Joe Hughes]

While adding the ability to edit folder titles in 330023, I ran into the issue that after the title is changed, any UI that's already onscreen isn't updated.  (This happens in both the Places window and the toolbar.)  However, the value is sticking; windows that are opened after that show the correct values.

Comment 1

[Brett Wilson]

Attachment: Untested patch

This patch is untested because I couldn't figure out how to rename folders. Joe, perhaps you can put this in your build and see if it works? If you don't feel like that I'll just wait until you've checked in your UI for changing folders. If you do test it, make sure you try having the view sorted by title: the item should move to its new position when the title changes.

Comment 2

[Joe Hughes]

Brett, I landed 330023 last night, so now you should be able to test your change by right-clicking on a bookmark folder and using Properties/Get Info.

Comment 3

[Brett Wilson]

Attachment: Tested patch

Comment 4

[Brett Wilson]

On branch and trunk

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv