331234 - Search engine icons missing for amazon, cc and eBay on zh-TW 1.0.8

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Tracy Walker [:tracy]]

seen with the latest respin of Fx 1.0.8 on zh-TW on Windows

this regressed since 1.0.7.  Marcia tested the original 1.0.8 zh-TW build a few weeks ago. She doesn't recall the icons being missing at that time.  Based on that, it seems this has regressed since the Yahoo default search engine changes were made.

Comment 1

[Tracy Walker [:tracy]]

The 1.0.8rc2 candidate build from 0310 has Yahoo search as default and is also missing the icons for amazon, cc and ebay.  I don't have any other zh-TW build between 1.0.7 and then.

Comment 2

[Tim Riley [:timr]]

We don't have any contractual requirements with Amazon.com, etc.  How critical is this to us or the L10n community?  We do need to fix this?  Probably should.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Hmm, the icons in the build I downloaded from http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/1.0.8-candidates/firefox-1.0.8.zh-TW.win32.zip do seem corrupted, but the icons in CVS seem OK (/l10n/mozilla/browser/locales/zh-TW/searchplugins on AVIARY_1_0_20040515_BRANCH). Maybe this is a build issue?

Comment 4

[Axel Hecht [:Pike]]

The usual suspect, those files are not -kb.
The regression may be that the build machine switched default line endings.

This may affect many more builds then :-/. I'm checkout out more aviary of the
aviary l10n right now.

Notes: yahoo-tw isn't -kb as well, but the yahoo icon is resistant against that
problem, the ebay icon itself is not the right one, too, AFAICT.

Comment 5

[Tim Riley [:timr]]

We need to fix this!

Comment 6

[Axel Hecht [:Pike]]

I'm doing the cvs admin -kb dance for a bunch of locales. What I did was 
cvs admin -kb, cvs update, verify the image in my local check out.

The list of affected files will be in the attachement coming up, it's lengthy.

Not taking the bug as I leave the verification of the fix to someone at either 
build or qa. And it doesn't really pay off to reassign the bug for 5 minutes.
When I attach the file, I'm done.

Comment 7

[Axel Hecht [:Pike]]

Attachment: cvs status log, locale name, filename, Sticky Options.

Here is the status of the files before I did the cvs admin dance.

I didn't fix the ebay icon for zh-TW, which seems to be a badly scaled version
of their logo.

Verified all changed files in my check-out after an update. Ready to respin and
verification in a build (or a few).

Comment 8

[Axel Hecht [:Pike]]

Trying davel's radar magic.

Comment 9

[Tim Riley [:timr]]

Axel- Why did you take off the blocking-aviary1.0.8 flag and put it back to "?".  Also, this is fixed in fixed-aviary1.0.8, right?  Please add this keyword!

Preed- Where is this in your queue?  It is ready for re-spin.

Comment 10

[Axel Hecht [:Pike]]

The flag setting was probably a reload badness, sorry for that. I can't grant it
back, though.

I didn't resolve this bug nor mark it fixed-aviary1.0.8 as this is a mix between
cvs rep and build machine, which I don't fully control. Thus we need to actually
test the builds. That's why I just added rft.

Comment 11

[Tim Riley [:timr]]

The blocking flag was accidently changes.  Setting it back to "+".

Axel- The rtf (ready to test) status whiteboard is a good way of letting us know this needs to be tested.  This situation is a little awkward.  Normally the fixed keyword is set and then we run a report of all fixed bugs for a particular relelase that are rtf rather than looking for all rtf bugs.  We'll get this build and tested.

Comment 12

[Jay Patel [:jay]]

If this is blocking, what's the status?  Will this be fixed in the next set of 1.0.8 l10n respins?

Comment 13

[J. Paul Reed [:preed]]

Axel changed this before the last round of 1.0.8 respins, so it *should* be testable; grab one of the builds, and see if it's fixed. If not, let me know, and we'll figure out the status.

But as I remember, he changed it at the on/offsite and the 1.0.8 respins were done after that.

Comment 14

[Tracy Walker [:tracy]]

This is fixed in the Windows Firefox 1.0.8 zh-TW locale of 0401

marking FIXED