331299 - op_noacc.c: In function `main': 94: warning: control reaches end of non-void function

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P2)

Description

[timeless]

/Users/timeless/mozilla/nsprpub/pr/tests/op_noacc.c: In function `main':
/Users/timeless/mozilla/nsprpub/pr/tests/op_noacc.c:94: warning: control reaches end of non-void function

Comment 1

[timeless]

Attachment: oops. wrong bug

Comment 2

[timeless]

Attachment: return fail more often?

Comment 3

[Atul Aggarwal]

Current warnings:
/mozilla/mozilla-central/nsprpub/pr/tests/op_noacc.c: In function ‘main’:
/mozilla/mozilla-central/nsprpub/pr/tests/op_noacc.c:72:5: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wparentheses]
/mozilla/mozilla-central/nsprpub/pr/tests/op_noacc.c:82:1: warning: control reaches end of non-void function [-Wreturn-type]

Comment 4

[Atul Aggarwal]

Attachment: Patch v1

Comment 5

[Benjamin Smedberg]

Comment on attachment 583861 [details] [diff] [review]
Patch v1

I am not an NSPR peer.

Comment 6

[Wan-Teh Chang]

Comment on attachment 583861 [details] [diff] [review]
Patch v1

r=wtc.  Thanks for the patch.

>+    if (err01 == NULL) {
>+        if (PR_GetError() == PR_NO_ACCESS_RIGHTS_ERROR) {
>+            printf ("error code is %d\n",PR_GetError());
>+            printf ("PASS\n");
>+            return 0;
>+        }
>+    }

In this form, the nested if statements can be merged with &&:

    if (err01 == NULL && PR_GetError() == PR_NO_ACCESS_RIGHTS_ERROR) {
        printf ("error code is %d\n",PR_GetError());
        printf ("PASS\n");
        return 0;
    }

We can also attempt more cleanup.  For example, it may
make sense to print the error code whenever PR_Open fails.
In that form, we would need the nested if statements:

    if (err01 == NULL) {
        int error = PR_GetError();
        printf ("error code is %d\n", error);
        if (error == PR_NO_ACCESS_RIGHTS_ERROR) {
            printf ("PASS\n");
            return 0;
        }
    }

Comment 7

[Atul Aggarwal]

Attachment: Patch v1.01

Agreeing to all the changes suggested.

Comment 8

[(not currently active) Ted Mielczarek]

Sorry this patch sat around so long, I checked it into NSPR CVS for you:
Checking in pr/tests/op_noacc.c;
/cvsroot/mozilla/nsprpub/pr/tests/op_noacc.c,v  <--  op_noacc.c
new revision: 3.10; previous revision: 3.9
done

Comment 9

[Atul Aggarwal]

Thanks a lot Ted.