Closed Bug 331333 Opened 18 years ago Closed 18 years ago

Do not link libthebes into libgkwidget as a SHARED_LIBRARY_LIB

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: engel, Assigned: engel)

References

Details

Attachments

(1 file)

Do not link libthebes into libgkwidget as a SHARED_LIBRARY_LIBS
918 bytes, patch
pavlov
: review+
Details | Diff | Splinter Review 
Among several other patches, this fix was proposed by Chris Seawood in Bug
328499, Comment 34; "libthebes is a dynamic lib so don't attempt to link it into libgkwidget as a SHARED_LIBRARY_LIB."

Note that thebes is already linked here,
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/widget/src/build/Makefile.in&rev=1.61&mark=69-71#50
Tested in MinGW build, but not in VC8.
Blocks: 328499
Attachment #215886 - Flags: review?(vladimir) → review+
Assignee: nobody → engel
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: