Closed
Bug 331344
Opened 19 years ago
Closed 19 years ago
Crash [@ nsTableRowFrame::CollapseRowIfNecessary] involving tables, visibility:collapse, direction:rtl
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
VERIFIED
FIXED
People
(Reporter: jruderman, Assigned: bernd_mozilla)
References
Details
(Keywords: crash, rtl, testcase)
Crash Data
Attachments
(2 files)
|
224 bytes,
text/html
|
Details | |
|
2.27 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
|
Reporter | |
Comment 1•19 years ago
|
||
|
||
Comment 2•19 years ago
|
||
Deosn't crash in Mozilla1.7, so this is a regression. A regression range might be useful.
The stack signature is pretty new, bug 326551
3.122 bmlk%gmx.de 2006-03-03 21:26 Make visibility:collapse work again after the display list change. Implement overflow handling and view synchronization for collapsed frames. bug 326551 r/sr=roc
Assignee: nobody → bernd_mozilla
OS: MacOS X → All
Hardware: Macintosh → All
http://lxr.mozilla.org/mozilla/source/layout/tables/nsTableRowFrame.cpp#1591 the loop counts wrong. And where I did learn not to assert that the colframe is not null and not to bail out reminds a mystery.
I did not add the asserts, as the other code around does not do it. If the cols are zero one gets clue pretty fast.
Attachment #216022 -
Flags: superreview?(roc)
Attachment #216022 -
Flags: review?(roc)
Attachment #216022 -
Flags: superreview?(roc)
Attachment #216022 -
Flags: superreview+
Attachment #216022 -
Flags: review?(roc)
Attachment #216022 -
Flags: review+
fixed
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•19 years ago
|
Blocks: randomclasses
|
||
Comment 7•19 years ago
|
||
Verified FIXED using trunk SeaMonkey 1.5a;Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060327 (09) with testcase: https://bugzilla.mozilla.org/attachment.cgi?id=215896&action=view
No longer crashing.
Status: RESOLVED → VERIFIED
|
||
Comment 9•17 years ago
|
||
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
|
||
Updated•13 years ago
|
Crash Signature: [@ nsTableRowFrame::CollapseRowIfNecessary]
You need to log in
before you can comment on or make changes to this bug.
Description
•