331374 - tdhtml regression, a regression from bug 234455

Status: RESOLVED INCOMPLETE

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Bug 234455 (centralize event dispatch) may have caused a sligth tdhtml regression.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

replaceimages: (3429/3413)   -> (3737/3721)

Other tests were affected only temporarily.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: bzip2-compressed profile (only way I could attach it)

This profile doesn't really show capturing event dispatch taking up 10% of the total time... Maybe 5% at most, and even that's doubtful.

That said, if we could avoid firing that event in cases like this where we know it's not needed, that would rock -- we could avoid posting our PLEvent too, etc...

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Some time ago I did some tests where I prevented load events firing (no PLEvents 
were created), but it didn't help here. I'll retest.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I'd like to see if Bug 335251 helps here, even a bit.

Comment 5

[Shawn Wilsher :sdwilsh]

I'm going through and marking old performance regression bugs as INCOMPLETE that are likely too old to be valid or get any traction on them.

Please re-open if you have more information or can demonstrate the regression still exists.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

And event handling has been optimized a bit, for example in Bug 458202.