331481 - Don't create unnecessary CSS rules

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[tor]

Comment 1

[tor]

Attachment: only create rule when presentation attribute present

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 216025 [details] [diff] [review]
only create rule when presentation attribute present

When you call RuleAbort, can you comment that this deletes the declaration? That API sucks.

   if (mAttrsAndChildren.AttrCount() == 0)
     return;

Not really needed anymore, I think. Elements with no attributes are likely to be rare, and now we won't be doing much work for such elements anyway.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

By the way, shouldn't nsSVGElement::UnsetAttr have

if (aNamespaceID == kNameSpaceID_None && IsAttributeMapped(aName)) {
  mContentStyleRule = nsnull;
}

like BeforeSetAttr does? It seems like right now we should have a bug where removing a presentational attribute will fire NS_ASSERTION(!mContentStyleRule), and if we remove the last attribute, and it's presentational, then we won't update the style rule.

Comment 4

[tor]

Attachment: testcase for removing presentation attribute - should turn black on click

Comment 5

[tor]

Both bits checked in.