331482 - Wrong line number reported in js console, with textarea in page

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[Martijn Wargers (dead)]

See upcoming testcase, I would expect to see:
"
Error: Martijn is not defined
Source File: file:///C:/Documents%20and%20Settings/mw22/Bureaublad/js_linenumber.htm
Line: 22
"

Instead, I get:
"
Error: Martijn is not defined
Source File: file:///C:/Documents%20and%20Settings/mw22/Bureaublad/js_linenumber.htm
Line: 18
"

That's 4 lines too early.
That's precisely the amount of returns I used inside the <textarea> tag, no coincidence.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

This was driver error on my part. The end condition needs to include newlines so that ConsumeUntil can count them.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checkin for this bug may have caused a 15% increase in number of allocations on balsa. See bug 333173.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

*** Bug 319312 has been marked as a duplicate of this bug. ***

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 217037 [details] [diff] [review]
Fix

Is this something that we'd consider taking for beta2? The patch simply makes sure that we count newlines in <textarea> and <title> correctly.