Closed Bug 331558 Opened 18 years ago Closed 18 years ago

Decompiler: Missing = in default xml namespace statement

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Version:
1.8 Branch
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.8.1

People

(Reporter: jerfa, Assigned: jerfa)

References

(
URL
)

Details

(Keywords: verified1.8.0.4, verified1.8.1)

Attachments

(1 file)

Add =
845 bytes, patch
mrbkap
: review+
brendan
: approval-branch-1.8.1+
jay
: approval1.8.0.4+
Details | Diff | Splinter Review 
For example, |default xml namespace = 'abc'| is printed as |default xml namespace 'abc'|. Since I'm not too familiar with E4X this drove me mad for a while when the lines I simply copied and pasted produced syntax errors. ;-)
Attached patch Add = — — Splinter Review 
I know I promised no more patches but this one was so trivial it doesn't count...
Attachment #216093 - Flags: review?(brendan)
Comment on attachment 216093 [details] [diff] [review]
Add =

brendan must have been asleep when he was writing this. I'll check it in.
Attachment #216093 - Flags: review?(brendan) → review+
Assignee: general → jerfa
Fix checked into trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 216093 [details] [diff] [review]
Add =

Totally safe one-constant-char-in-format-string change, good for 1.5.0.3.

/be
Attachment #216093 - Flags: approval1.8.0.3?
Attachment #216093 - Flags: approval-branch-1.8.1+
Comment on attachment 216093 [details] [diff] [review]
Add =

Please check in promptly on the 1.8.0 branch.  Thanks!
Attachment #216093 - Flags: approval1.8.0.3? → approval1.8.0.3+
Checking in regress-331558.js;
/cvsroot/mozilla/js/tests/e4x/Regress/regress-331558.js,v  <--  regress-331558
s
initial revision: 1.1
done
Flags: in-testsuite+
Checked in on both branches.
mozilla/js/src/jsopcode.c 3.89.2.8.2.5
mozilla/js/src/jsopcode.c 3.89.2.12
Keywords: fixed1.8.0.4, fixed1.8.1
Target Milestone: mozilla1.9alpha → mozilla1.8.1
Version: Trunk → 1.8 Branch
verified fixed 1.8.0.4, 1.8, 1.9 win/linux/mac 20060507/20060508 builds
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.0.4, fixed1.8.1 → verified1.8.0.4, verified1.8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: