331562 - lost padding-left in overflowing scrollable RTL blocks

Status: RESOLVED INVALID

(Core :: Layout: Text and Fonts, defect)

Description

[Hideo Saito]

Padding-left is disregarded in overflowing scrollable RTL blocks, although padding-right is displayed in overflowing scrollable LTR blocks.

Comment 1

[Hideo Saito]

Attachment: testcase

I think that padding-left on testcase should be displayed.
The reason is illustrated as follows.

If padding-left is |a|, content-width is |b| and available-width is |c|, |d| is overflowing-width.

          |--a-->----------b--------->
          |-------c-------->----d---->

Current reflowing is illustrated as follows, in the result, padding-left is lost.
          |-------c-------->
          |--a-->
       <----d----
       ----------b--------->

I think that the reflowing should be done as follows.

<----d----|-------c-------->
 --a-->----------b--------->

Comment 2

[Hideo Saito]

Attachment: test patch

Comment 3

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8]

What in the spec says this should work?  I can't find anything, although it does work for LTR.

The patch looks wrong.  You shouldn't need to add piles of code to fix this.

Comment 4

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8]

(Where is the code that makes this work for LTR?)

Comment 5

[Hideo Saito]

(In reply to comment #4)
> (Where is the code that makes this work for LTR?)

Following change removes padding-right in overflowing LTR blocks.

+++ nsBlockFrame.cpp	Sat Mar 25 22:28:46 2006
@@ -1260,17 +1260,17 @@ nsBlockFrame::ComputeFinalSize(const nsH
       if (NS_BLOCK_SPACE_MGR & mState) {
         // Include the space manager's state to properly account for the
         // extent of floated elements.
         nscoord xmost;
         if (aReflowState.mSpaceManager->XMost(xmost) &&
             computedWidth < xmost)
           computedWidth = xmost;
       }
-      computedWidth += borderPadding.right;
+      //computedWidth += borderPadding.right;
     }
 
     if (aState.GetFlag(BRS_COMPUTEMAXELEMENTWIDTH)) {
       // Add in border and padding dimensions to already computed
       // max-element-width values.
       maxElementWidth = aState.mMaxElementWidth +
         borderPadding.left + borderPadding.right;
     }

Comment 6

[Hideo Saito]

Padding-right is not already displayed in overflowing scrollable LTR blocks by the fix for Bug 300030. I think this report should be closed.

Comment 7

[:ehsan akhgari]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).