331600 - Remove code from _netbsd.h which we don't have permission to relicense

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Gervase Markham [:gerv]]

There is a small amount of code in nsprpub/pr/include/md/_netbsd.h which we don't have permission to relicence. I have agreed with the NetBSD maintainer that this code can be removed from our repository and, for now, will be added back using their packaging system.

This needs to be done on the trunk and 1.8 branch. I will attach separate patches for each.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1 for trunk

This patch is a fairly dumb reversal of https://bugzilla.mozilla.org/attachment.cgi?id=20022 , which is attached to bug 61746. No effort has been made, beyond visual inspection, to check whether it parses or builds. (I do not have access to a NetBSD machine.)

Gerv

Comment 2

[Gervase Markham [:gerv]]

Comment on attachment 216116 [details] [diff] [review]
Patch v.1 for trunk

Requesting permission to remove this code from wtc.

Gerv

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 216116 [details] [diff] [review]
Patch v.1 for trunk

Re-requesting permission from Bob Relyea due to wtc's absence.

Gerv

Comment 4

[Robert Relyea]

Unless I'm missing something, don't believe the patch will work on the following platforms: sparc_v9, powerpc, and mips (sparc has no stack pointer register location, powerpc's stack pointer changed from 3 to 2 and mips from 32 to 4).

If we don't care, I'm ok with this patch.

bob

Comment 5

[Gervase Markham [:gerv]]

It's not that we don't care in the abstract; but it is up to the NetBSD community to provide fixes for these issues, which are under a licence compatible with the licence of the file.

I will check this patch in.

Gerv

Comment 6

[Gervase Markham [:gerv]]

Checked in to trunk.

Checking in nsprpub/pr/include/md/_netbsd.h;
/cvsroot/mozilla/nsprpub/pr/include/md/_netbsd.h,v  <--  _netbsd.h
new revision: 3.17; previous revision: 3.16
done

Gerv

Comment 7

[Gervase Markham [:gerv]]

Turns out the branch patch is identical.

Checking in nsprpub/pr/include/md/_netbsd.h;
/cvsroot/mozilla/nsprpub/pr/include/md/_netbsd.h,v  <--  _netbsd.h
new revision: 3.13.2.3.32.1; previous revision: 3.13.2.3
done

Gerv

Comment 8

[Robert Relyea]

Comment on attachment 216116 [details] [diff] [review]
Patch v.1 for trunk

r+ based on gerv's response

Comment 9

[Robert Relyea]

to check into 3.11 you should get a 2nd review. Is that the branch you checked in below?

bob

Comment 10

[Gervase Markham [:gerv]]

Bob: I checked into the trunk and the MOZILLA_1_8_BRANCH. Is either of those 3.11?

Gerv

Comment 11

[Wan-Teh Chang]

Comment on attachment 216116 [details] [diff] [review]
Patch v.1 for trunk

If NetBSD has pthreads, I recommend that the Mozilla clients
use pthreads instead of NSPR's own user threads.  When pthreads
are used, the code removed by this patch is dead code.

The code removed by this patch is simple but not easy.  I
hope you understand the distinction I make between "simple"
and "easy".  The code has values that are hard to obtain
(e.g., the indices of the jmp_buf elements that need to be
set and the offset that needs to be subtracted from the
stack pointer), but the procedure to use those values can
be expressed in simple C code.  So it is more appropriate
to protect the intellectual property of this code with a
patent than a copyright.  Another way to look at this is
that if a competent NSPR programmer is given those values,
he can easily write the code.  So I'm surprised that we
have to remove the code.  However, since the code in question
is or will eventually be dead code, I won't worry about it.

Comment 12

[Wan-Teh Chang]

Gerv, please also check in the patch on the
NSPRPUB_PRE_4_2_CLIENT_BRANCH.

Comment 13

[Wan-Teh Chang]

I checked in the patch on the NSPRPUB_PRE_4_2_CLIENT_BRANCH
and NSPR_4_6_BRANCH.