331614 - window.open unnecessarily escapes all URLs (can't handle IDN/extended domain-names)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Michael]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060314 Ubuntu/dapper Epiphany/2.14 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060314 Ubuntu/dapper Epiphany/2.14 Firefox/1.5.0.1

window.open(var) cannot resolve the given url

where var = img.src = "./img/img.jpg"(passed to JS) on a IDN-domain

see: www.etk-füwa.de/?etk=home  // http://xn--etk-fwa-r2a.de/?etk=home
(click on the picture)

happens with FF 1.5+ (1.0.7 works)

Reproducible: Always



Expected Results:  
resolved the IDN correctly

Comment 1

[Nickolay_Ponomarev]

Confirmed with a trunk build from within the last week.

Firefox tries to access www.etk-f%fcwa.de and is unable to do that because of bug 309671.

Comment 2

[Nickolay_Ponomarev]

(In reply to comment #0)
> window.open(var) cannot resolve the given url
> 
> where var = img.src = "./img/img.jpg"(passed to JS) on a IDN-domain
> 
Er, that's not true. It's indeed <img src="./img/img.jpg">, but img.src (actually called document.T1.src) is "http://etk-füwa.de/img/team.jpg". So what actually happens, I think, is window.open("http://etk-füwa.de/img/team.jpg") is called and it escapes the unicode character in 1.5.

Comment 3

[Nickolay_Ponomarev]

I'm not familiar enough with IDN to know what exactly is wrong here apart from the fact that we can't load escaped URLs. I guess it would be interesting to know what has changed since 1.0 here (the return value of img.src?)

Comment 4

[Michael]

> I guess it would be interesting to
> know what has changed since 1.0 here (the return value of img.src?)

just tested... in 1.0.7 "http://www.etk-füwa.de" is transformed to the non-extended domain "http://xn--etk-fwa-r2a.de/" (i guess for security reasons.. there was a phishing-thing with IDN in the past). 

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: don't escape

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: testcase

Works with the patch, fails without.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 217983 [details] [diff] [review]
don't escape

r=bzbarsky.  I love it when removing code fixes bugs.  ;)

Comment 8

[Darin Fisher]

Comment on attachment 217983 [details] [diff] [review]
don't escape

sr=darin

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/dom/src/base/nsGlobalWindow.cpp 	1.838

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 217983 [details] [diff] [review]
don't escape

This has been on the trunk for a while with no known regressions, so I'd like to land it on the branch.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

mozilla/dom/src/base/nsGlobalWindow.cpp 	1.761.2.38

Comment 12

[:Gavin Sharp [email: [e-mail]]]

*** Bug 348054 has been marked as a duplicate of this bug. ***