331701 - Events created via dra'n'drop should be stored in selected calendar

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Stefan Sitter [:ssitter]]

Events created via dra'n'drop should be stored in selected calendar

Steps to Reproduce:
1. Create two or more local calendars (use colors for better differentiation)
2. Go to 'Calendars' tab and select any calendar except the first one
3. Go to Day or Week view and create an event via drag and drop

Actual Results:
The event is created and stored in the first calendar that is listed in 'Calendars' tab regardless which one is selected. Open the Edit Event dialog to verify this.

Expected Results:
The event is created and stored in the currently selected calendar.

Additional Information:
Tested with Sunbird 0.3a1+ (20060325). It works in Lightning so this bug is Sunbird only.

Comment 1

[Joey Minta]

Attachment: simple patch

This is the simple fix.  The trickier, perhaps more correct, fix is to set the composite calendar's default calendar whenever the listbox gets selected.  Unfortunately, this seemed to keep throwing me into an infinite loop, which was highly uncool.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 216220 [details] [diff] [review]
simple patch

>-        doTransaction('add', event, aCalendar, null, null);
>+        var calendar = getSelectedCalendarOrNull() || aCalendar;
>+        doTransaction('add', event, calendar, null, null);

This will always create the calendar in the selected calendar, and ignore the passed in parameter. Shouldn't it be the other way around? use aCalendar is available, otherwise the default. That seems to be what lightning does.

Comment 3

[Joey Minta]

Attachment: correct patch

This is the correct patch.  The composite calendar actually uses a calendar preference internally, which was sticking us in an infinite loop when setCalendarUI() rebuilt the list, and hence reselected.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 216369 [details] [diff] [review]
correct patch

yes, this looks better.
r=mvl

Comment 5

[Joey Minta]

Patch checked in.

Comment 6

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060929 Sunbird/0.3

Comment 7

[Damian Szczepanik]

Litmus testcase 2610 created