331707 - [BeOS] Build Broken in nsAnnotationService.cpp

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P4)

Description

[Doug Shelton]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060318 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060318 Firefox/1.6a1

Bustage occured sometime after 2006-03-18.

nsAnnotationService.cpp
c++ -o nsAnnotationService.o -c  -DMOZILLA_INTERNAL_API -DOSTYPE=\"BeOS6.0.1\" -DOSARCH=\"BeOS\" -DBUILD_ID=0000000000 -I/boot/home/develop/mozilla/browser/components/places/src/../../build -I../../../../dist/include/xpcom -I../../../../dist/include/string -I../../../../dist/include/history -I../../../../dist/include/docshell -I../../../../dist/include/rdf -I../../../../dist/include/dom -I../../../../dist/include/morkreader -I../../../../dist/include/pref -I../../../../dist/include/necko -I../../../../dist/include/intl -I../../../../dist/include/layout -I../../../../dist/include/locale -I../../../../dist/include/unicharutil -I../../../../dist/include/autocomplete -I../../../../dist/include/storage -I../../../../dist/include/uconv -I../../../../dist/include/htmlparser -I../../../../dist/include/content -I../../../../dist/include/txmgr -I../../../../dist/include/xmlextras -I../../../../dist/include/caps -I../../../../dist/include/xpconnect -I../../../../dist/include/js -I../../../../dist/include/nkcache -I../../../../dist/include/widget -I../../../../dist/include   -I../../../../dist/include/places -I../../../../dist/include/nspr       -fPIC   -frtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-multichar -Wno-long-long -pedantic -pipe  -DNDEBUG -DTRIMMED -O3 -march=i686 -mcpu=i686 -frerun-cse-after-loop -frerun-loop-opt   -DMOZILLA_CLIENT -include ../../../../mozilla-config.h -Wp,-MD,.deps/nsAnnotationService.pp /boot/home/develop/mozilla/browser/components/places/src/nsAnnotationService.cpp
/boot/home/develop/mozilla/opt-Zeta/dist/include/xpcom/nsAutoPtr.h: In method `nsRefPtr<nsNavHistoryResult>::~nsRefPtr()':
/boot/home/develop/mozilla/browser/components/places/src/nsNavHistoryResult.h:658:   instantiated from here
In file included from /boot/home/develop/mozilla/browser/components/places/src/nsNavHistory.h:76,
                 from /boot/home/develop/mozilla/browser/components/places/src/nsAnnotationService.cpp:41:
/boot/home/develop/mozilla/opt-Zeta/dist/include/xpcom/nsAutoPtr.h:956: invalid use of undefined type `class nsNavHistoryResult'
/boot/home/develop/mozilla/browser/components/places/src/nsNavHistoryResult.h:53: forward declaration of `class nsNavHistoryResult'
make[7]: *** [nsAnnotationService.o] Error 1
make[7]: Leaving directory `/boot/home/develop/mozilla/opt-Zeta/browser/components/places/src'
make[6]: *** [libs] Error 2
make[6]: Leaving directory `/boot/home/develop/mozilla/opt-Zeta/browser/components/places'
make[5]: *** [libs] Error 2
make[5]: Leaving directory `/boot/home/develop/mozilla/opt-Zeta/browser/components'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/boot/home/develop/mozilla/opt-Zeta/browser'
make[3]: *** [libs_tier_99] Error 2
make[3]: Leaving directory `/boot/home/develop/mozilla/opt-Zeta'
make[2]: *** [tier_99] Error 2
make[2]: Leaving directory `/boot/home/develop/mozilla/opt-Zeta'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/boot/home/develop/mozilla/opt-Zeta'
make: *** [build] Error 2
$    

Reproducible: Always

Comment 1

[Doug Shelton]

based on console output, this could be related to one of several changes committed to nsNavHistoryResult.cpp

Comment 2

[tqh]

Attachment: Removed forward ref of nsNavHistoryResult

Moved the nsNavHistoryResult class declaration so it doesn't need a forward ref.

Comment 3

[Doug Shelton]

(In reply to comment #2)
> Created an attachment (id=216256) [edit]
> Removed forward ref of nsNavHistoryResult
> 
> Moved the nsNavHistoryResult class declaration so it doesn't need a forward
> ref.
> 

Patch applied here and now able to build.  Looks like this fixes the bustage.  Thanks, tqh!

Comment 4

[tqh]

Who do I ask for review from on this bug?

Also need someone to commit on review.

Comment 5

[Doug Shelton]

(In reply to comment #4)
> Who do I ask for review from on this bug?
> 
> Also need someone to commit on review.
> 
Other changes to this file were made by [e-mail].  I'd ask him for review.

Comment 6

[tqh]

Comment on attachment 216256 [details] [diff] [review]
Removed forward ref of nsNavHistoryResult

r?

(Also need someone to checkin on review)

Comment 7

[Brett Wilson]

Comment on attachment 216256 [details] [diff] [review]
Removed forward ref of nsNavHistoryResult

I'll check it in shortly.

Comment 8

[Brett Wilson]

Checked in on branch and trunk

Comment 9

[Doug Shelton]

(In reply to comment #8)
> Checked in on branch and trunk
> 
Thank you, Brett!

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv