Prevent user from resizing bookmarks dialog in such a way that contents are truncated




Bookmarks & History
12 years ago
8 years ago


(Reporter: Joe Hughes, Assigned: Joe Hughes)


2.0 Branch
Firefox 2 beta1

Firefox Tracking Flags

(Not tracked)


(Whiteboard: swag 1)


(1 attachment, 1 obsolete attachment)



12 years ago


12 years ago
Whiteboard: swag 1

Comment 1

12 years ago
Created attachment 218831 [details] [diff] [review]
Make the Bookmark & Folder properties dialog non-resizable and decrease its width
Attachment #218831 - Flags: superreview?(bugs)
Attachment #218831 - Flags: review?(annie.sullivan)
Comment on attachment 218831 [details] [diff] [review]
Make the Bookmark & Folder properties dialog non-resizable and decrease its width
Attachment #218831 - Flags: superreview?(bugs) → superreview+


12 years ago
Attachment #218831 - Flags: review?(annie.sullivan) → review+
I just built with this on Windows, with "Extra Large Fonts" turned on for my tired eyes: the Bookmark Properties dialog has two buttons, "Save Changes" and "Delete Bookma".

And don't forget that those words will also be translated into other languages: see various and sundry bugs over the years, from the German l18n team in particular, as we size things perfectly for English words in normal size fonts and then prevent people from even resizing to survive our mistake, to... to... what was the gain here again?
Blocks: 329607

Comment 4

12 years ago
Created attachment 219661 [details] [diff] [review]
Updated patch to deal with wider button labels

You're right, Phil, I was overlooking usage cases with wider labels.  Give the updated version a spin...
Attachment #218831 - Attachment is obsolete: true
Attachment #219661 - Flags: review?(philringnalda)

Comment 5

12 years ago
I'm going to WONTFIX this, because as Phil pointed out in IRC conversation, having a fixed size makes you unable to read the names of folders which are sufficiently deep in a tree (especially if you have a large font).  Ideally, it would be possible to specify a minimum size for the dialog and have it enforced, but that isn't possible at this point.  Replacement bug 335323 will add all the functionality from the attached patch, but without the non-resizability part.
Last Resolved: 12 years ago
Resolution: --- → WONTFIX
Attachment #219661 - Flags: review?(philringnalda)
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.