Closed
Bug 331719
Opened 19 years ago
Closed 19 years ago
Problem with String.replace running with WAY_TOO_MUCH_GC
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla1.9alpha1
People
(Reporter: dbaron, Assigned: brendan)
References
()
Details
(Keywords: verified1.8.0.4, verified1.8.1)
Attachments
(1 file)
|
1.55 KB,
patch
|
mrbkap
:
review+
brendan
:
approval-branch-1.8.1+
dveditz
:
approval1.8.0.4+
|
Details | Diff | Splinter Review |
When I run with WAY_TOO_MUCH_GC, I see the text in the first button of each confirmation dialog being /\&\&/g followed by the accesskey. The problem is that the code here:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/commonDialog.js&rev=1.11&mark=91#70
ends up changing aLabel from "No" to "/\&\&/g".
|
Assignee | |
Comment 1•19 years ago
|
||
Should have looked for js_Clone when I fixed the js_CloneFunctionObject call-sites to home sp and pc.
/be
Attachment #216264 -
Flags: review?(mrbkap)
|
|
Assignee | |
Updated•19 years ago
|
Assignee: general → brendan
Flags: blocking1.8.1+
Flags: blocking1.8.0.3?
OS: Linux → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha
|
Reporter | |
Comment 2•19 years ago
|
||
Yep, that fixes it for me.
|
|
Assignee | |
Updated•19 years ago
|
Attachment #216264 -
Flags: approval1.8.0.3?
Attachment #216264 -
Flags: approval-branch-1.8.1+
|
||
Comment 3•19 years ago
|
||
Comment on attachment 216264 [details] [diff] [review]
fix
r=mrbkap
Attachment #216264 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Fixed on trunk and 1.8 branch. Another js1.6 candidate. Needs to be approved for 1.8.0.3.
/be
Blocks: js1.6rc1
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
|
||
Comment 5•19 years ago
|
||
SAVE_SP_AND_PC doesn't exist on the 1.8 branch, this patch made the tinderboxen red.
|
|
Assignee | |
Comment 6•19 years ago
|
||
Sorry, fixed to use SAVE_SP(fp) on the 1.8 branch.
/be
|
||
Updated•19 years ago
|
Flags: blocking1.8.0.3? → blocking1.8.0.3+
|
|
||
Comment 7•19 years ago
|
||
Comment on attachment 216264 [details] [diff] [review]
fix
approved for 1.8.0 branch, a=dveditz for drivers
Attachment #216264 -
Flags: approval1.8.0.3? → approval1.8.0.3+
|
|
Reporter | |
Comment 9•19 years ago
|
||
This broke the 1.8.0 branch tree since SAVE_FP_AND_PC doesn't exist there.
|
|
Reporter | |
Comment 10•19 years ago
|
||
I landed the same change there that landed on the 1.8 branch.
|
|
Assignee | |
Comment 11•19 years ago
|
||
Argh, I should have remembered this 1.8{.0,} branch difference from trunk. Sorry, and thanks again for fixing it.
/be
|
||
Comment 12•19 years ago
|
||
1.5.0.4 debug WAY_TOO_MUCH GC windows/linux "No".replace(/\&\&/g, "&") == "No"
Keywords: fixed1.8.0.4 → verified1.8.0.4
|
|
||
Comment 13•18 years ago
|
||
Checking in regress-331719.js;
/cvsroot/mozilla/js/tests/js1_5/GC/regress-331719.js,v <-- regress-331719.js
initial revision: 1.1
Flags: in-testsuite+
|
|
||
Comment 14•18 years ago
|
||
verified fixed 1.8, 1.9 20060807 linux.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•