331719 - Problem with String.replace running with WAY_TOO_MUCH_GC

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When I run with WAY_TOO_MUCH_GC, I see the text in the first button of each confirmation dialog being /\&\&/g followed by the accesskey.  The problem is that the code here:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/commonDialog.js&rev=1.11&mark=91#70

ends up changing aLabel from "No" to "/\&\&/g".

Comment 1

[Brendan Eich [:brendan]]

Attachment: fix

Should have looked for js_Clone when I fixed the js_CloneFunctionObject call-sites to home sp and pc.

/be

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yep, that fixes it for me.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 216264 [details] [diff] [review]
fix

r=mrbkap

Comment 4

[Brendan Eich [:brendan]]

Fixed on trunk and 1.8 branch.  Another js1.6 candidate.  Needs to be approved for 1.8.0.3.

/be

Comment 5

[:Gavin Sharp [email: [e-mail]]]

SAVE_SP_AND_PC doesn't exist on the 1.8 branch, this patch made the tinderboxen red.

Comment 6

[Brendan Eich [:brendan]]

Sorry, fixed to use SAVE_SP(fp) on the 1.8 branch.

/be

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 216264 [details] [diff] [review]
fix

approved for 1.8.0 branch, a=dveditz for drivers

Comment 8

[Brendan Eich [:brendan]]

Fixed on 1.8.0 branch.

/be

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This broke the 1.8.0 branch tree since SAVE_FP_AND_PC doesn't exist there.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I landed the same change there that landed on the 1.8 branch.

Comment 11

[Brendan Eich [:brendan]]

Argh, I should have remembered this 1.8{.0,} branch difference from trunk.  Sorry, and thanks again for fixing it.

/be

Comment 12

[Bob Clary [:bc] (inactive)]

1.5.0.4 debug WAY_TOO_MUCH GC windows/linux "No".replace(/\&\&/g, "&") == "No"

Comment 13

[Bob Clary [:bc] (inactive)]

Checking in regress-331719.js;
/cvsroot/mozilla/js/tests/js1_5/GC/regress-331719.js,v  <--  regress-331719.js
initial revision: 1.1

Comment 14

[Bob Clary [:bc] (inactive)]

verified fixed 1.8, 1.9 20060807 linux.