331737 - "About Sunbird" menu item appears in two places

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Matthew (lilmatt) Willis]

On the Mac, the "About Sunbird" menuitem appears in two places:
1) under the "Sunbird" application menu (where it _ought_ to be)
2) under the "Help" menu (where it shouldn't, at least on Mac OS X)

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - ifdefs "About Sunbird" appropriately for Mac OS X

Comment 2

[Joey Minta]

Comment on attachment 216284 [details] [diff] [review]
rev0 - ifdefs "About Sunbird" appropriately for Mac OS X

+
+<!-- On Mac OS X, the "About Sunbird" menuitem belongs under the "Sunbird" menu.
+   - We hide it (and its separator) here, but we don't remove it or ifdef it
+   - out, as doing so will prevent it from appearing at all! -->
+#ifndef XP_MACOSX

Couple of things about this comment: (1) It shouldn't be aligned all the way to the left. (2) It's going to appear a bit odd in a post-processed file.  Can you juggle its position so that it will make more sense in both versions? (3) The parenthetical remark about the separator seems incorrect.  You are in fact ifdef-ing it.

r=jminta with that tidied up.

Comment 3

[Matthew (lilmatt) Willis]

Attachment: rev1 - now with jminta's feedback

Comment 4

[Joey Minta]

Comment on attachment 216318 [details] [diff] [review]
rev1 - now with jminta's feedback

r=jminta :-)

Comment 5

[Matthew (lilmatt) Willis]

checked in to 1.8 branch and trunk