"Email This Link…" doesn't appear for links whose "content" is an image

RESOLVED FIXED in Camino1.5

Status

Camino Graveyard
Toolbars & Menus
--
minor
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: froodian (Ian Leue))

Tracking

({fixed1.8.1.1, polish})

unspecified
Camino1.5
PowerPC
Mac OS X
fixed1.8.1.1, polish

Details

(URL)

Attachments

(1 attachment)

25.15 KB, application/zip
Smokey Ardisson (offline for a while; not following bugs - do not email)
: review+
Stuart Morgan
: superreview+
Details
Bug 227803 added what is now known as "Email This Link…" to the context menu.  However, if the content between the <a></a> tag is an image, the "Email This Link…" item does not appear.

STR:
1. Visit the link above
2. Hover over the Mozilla banner; note the cursor turns into the hand to indicate a link
3. Ctrl-click the banner; note the absence of "Email This Link…" in the CM

I'm aware this is borderline bloat, but I think pink's comments in bug 227803 comment 5 are valid, and what's more, it's confusing that the item appears in the CM for some links not others.  (I tried to use that CM option today to mail a link to someone's forum profile, but the link was a little "button" image, so the CM item wasn't there....)

Comment 1

11 years ago
Taking this bug.
Assignee: mikepinkerton → mozilla

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

11 years ago
Depends on: 342780
Bruce, do you think you will have time to get to this in the next month or so?

(The menu is "already" ported out of the nib into code, just waiting for review in bug 342780....)
(Assignee)

Comment 3

11 years ago
BruceD, if you don't mind, taking.  I'll put up a fix for this once the nib in bug 343767 lands.
Assignee: mozilla → stridey
Status: ASSIGNED → NEW
(Assignee)

Comment 4

11 years ago
Created attachment 243857 [details]
New BrowserWindow.nib

This adds the menu item for the image/link context menu, and changes ... to … in all the context menus in that nib
Attachment #243857 - Flags: review?(alqahira)
Comment on attachment 243857 [details]
New BrowserWindow.nib

This isn't the right fix, since it ends up adding the "Email this Link" to Image links whose link is a mailto: url.
Attachment #243857 - Flags: review?(alqahira) → review-
Comment on attachment 243857 [details]
New BrowserWindow.nib

Well, it would help if my testcase didn't have a typo in it :P

This does work; sorry :(
Attachment #243857 - Flags: superreview?(stuart.morgan)
Attachment #243857 - Flags: review-
Attachment #243857 - Flags: review+

Comment 7

11 years ago
Comment on attachment 243857 [details]
New BrowserWindow.nib

sr=me. w00t!
Attachment #243857 - Flags: superreview?(stuart.morgan) → superreview+
(Assignee)

Comment 8

11 years ago
Checked in on 1.8branch and trunk.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.