331745 - "Email This Link…" doesn't appear for links whose "content" is an image

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Bug 227803 added what is now known as "Email This Link…" to the context menu.  However, if the content between the <a></a> tag is an image, the "Email This Link…" item does not appear.

STR:
1. Visit the link above
2. Hover over the Mozilla banner; note the cursor turns into the hand to indicate a link
3. Ctrl-click the banner; note the absence of "Email This Link…" in the CM

I'm aware this is borderline bloat, but I think pink's comments in bug 227803 comment 5 are valid, and what's more, it's confusing that the item appears in the CM for some links not others.  (I tried to use that CM option today to mail a link to someone's forum profile, but the link was a little "button" image, so the CM item wasn't there....)

Comment 1

[Bruce Davidson]

Taking this bug.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Bruce, do you think you will have time to get to this in the next month or so?

(The menu is "already" ported out of the nib into code, just waiting for review in bug 342780....)

Comment 3

[froodian (Ian Leue)]

BruceD, if you don't mind, taking.  I'll put up a fix for this once the nib in bug 343767 lands.

Comment 4

[froodian (Ian Leue)]

Attachment: New BrowserWindow.nib

This adds the menu item for the image/link context menu, and changes ... to … in all the context menus in that nib

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 243857 [details]
New BrowserWindow.nib

This isn't the right fix, since it ends up adding the "Email this Link" to Image links whose link is a mailto: url.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 243857 [details]
New BrowserWindow.nib

Well, it would help if my testcase didn't have a typo in it :P

This does work; sorry :(

Comment 7

[Stuart Morgan]

Comment on attachment 243857 [details]
New BrowserWindow.nib

sr=me. w00t!

Comment 8

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk.