Last Comment Bug 331745 - "Email This Link…" doesn't appear for links whose "content" is an image
: "Email This Link…" doesn't appear for links whose "content" is an image
Status: RESOLVED FIXED
: fixed1.8.1.1, polish
Product: Camino Graveyard
Classification: Graveyard
Component: Toolbars & Menus (show other bugs)
: unspecified
: PowerPC Mac OS X
-- minor (vote)
: Camino1.5
Assigned To: froodian (Ian Leue)
:
:
Mentors:
http://bonsai.mozilla.org/cvsquery.cg...
Depends on: 342780
Blocks:
  Show dependency treegraph
 
Reported: 2006-03-25 22:37 PST by Smokey Ardisson (offline for a while; not following bugs - do not email)
Modified: 2006-10-29 09:28 PST (History)
4 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
New BrowserWindow.nib (25.15 KB, application/zip)
2006-10-27 16:41 PDT, froodian (Ian Leue)
alqahira: review+
stuart.morgan+bugzilla: superreview+
Details

Description User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2006-03-25 22:37:54 PST
Bug 227803 added what is now known as "Email This Link…" to the context menu.  However, if the content between the <a></a> tag is an image, the "Email This Link…" item does not appear.

STR:
1. Visit the link above
2. Hover over the Mozilla banner; note the cursor turns into the hand to indicate a link
3. Ctrl-click the banner; note the absence of "Email This Link…" in the CM

I'm aware this is borderline bloat, but I think pink's comments in bug 227803 comment 5 are valid, and what's more, it's confusing that the item appears in the CM for some links not others.  (I tried to use that CM option today to mail a link to someone's forum profile, but the link was a little "button" image, so the CM item wasn't there....)
Comment 1 User image Bruce Davidson 2006-03-27 01:14:08 PST
Taking this bug.
Comment 2 User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2006-08-13 02:25:31 PDT
Bruce, do you think you will have time to get to this in the next month or so?

(The menu is "already" ported out of the nib into code, just waiting for review in bug 342780....)
Comment 3 User image froodian (Ian Leue) 2006-10-26 16:39:03 PDT
BruceD, if you don't mind, taking.  I'll put up a fix for this once the nib in bug 343767 lands.
Comment 4 User image froodian (Ian Leue) 2006-10-27 16:41:34 PDT
Created attachment 243857 [details]
New BrowserWindow.nib

This adds the menu item for the image/link context menu, and changes ... to … in all the context menus in that nib
Comment 5 User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2006-10-27 17:08:22 PDT
Comment on attachment 243857 [details]
New BrowserWindow.nib

This isn't the right fix, since it ends up adding the "Email this Link" to Image links whose link is a mailto: url.
Comment 6 User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2006-10-28 00:42:19 PDT
Comment on attachment 243857 [details]
New BrowserWindow.nib

Well, it would help if my testcase didn't have a typo in it :P

This does work; sorry :(
Comment 7 User image Stuart Morgan 2006-10-28 21:40:22 PDT
Comment on attachment 243857 [details]
New BrowserWindow.nib

sr=me. w00t!
Comment 8 User image froodian (Ian Leue) 2006-10-29 09:28:33 PST
Checked in on 1.8branch and trunk.

Note You need to log in before you can comment on or make changes to this bug.