Camino (1.8 branch) builds are broken

VERIFIED FIXED

Status

VERIFIED FIXED
13 years ago
13 years ago

People

(Reporter: mark, Assigned: mikepinkerton)

Tracking

({fixed1.8.1})

1.8 Branch
PowerPC
Mac OS X
fixed1.8.1

Details

(Reporter)

Description

13 years ago
 
(Reporter)

Comment 1

13 years ago
The breakage was caused by this patch, which does not appear to have an associated bug number:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=Makefile.in&branch=1.33.18.1&root=/cvsroot&subdir=mozilla/xpfe&command=DIFF_FRAMESET&rev1=1.33&rev2=1.33.18.1

Doug, what were you trying to do with that logic flip?  Camino needs to build in the suite dirs.  We're getting an incomplete embed.jar, and the 1.8 branch universal build has gone red because it depends on buildconfig.html in embed.jar, which is now not present.  The bustage:

http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1143142020.7932.gz&fulltext=1
(Reporter)

Comment 2

13 years ago
I've checked in the following bustage fix for Camino at xpfe/Makefile.in:

-ifneq (,$(MOZ_THUNDERBIRD)$(MOZ_SUITE))
+ifneq (,$(MOZ_THUNDERBIRD)$(MOZ_SUITE)$(filter macbrowser,$(MOZ_BUILD_APP)))

but I wonder why this needs to be done differently from the trunk, which still uses this logic:

ifneq (,$(MOZ_PHOENIX)$(MOZ_XULRUNNER))
else

(possibly with $(MINIMO) added if it too only wants browser/public and browser/src?)

Comment 3

13 years ago
Sorry for the bustage.

So this change didn't make it to the branch because we will probably not ifdef MINIMO but instead use a "embedding profile" define.  see bug 331431.

Is it safe to close this bug as fixed?
(Reporter)

Comment 4

13 years ago
OK.  I look forward to seeing some of that stuff stripped out of embed.jar.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.