Closed
Bug 331780
Opened 19 years ago
Closed 17 years ago
Please don't build most of the uconv modules when building native uconv
Categories
(Core :: Internationalization, enhancement)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla1.9beta2
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
363 bytes,
patch
|
jshin1987
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.8.0.1) Gecko/20060313 Debian/1.5.dfsg+1.5.0.1-4 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.8.0.1) Gecko/20060313 Debian/1.5.dfsg+1.5.0.1-4 Firefox/1.5.0.1
Most of the uconv modules are useless when building with native uconv, but still built.
Patch following.
Reproducible: Always
Assignee | ||
Comment 1•19 years ago
|
||
Patch to avoid building what is not necessary
Attachment #216331 -
Flags: review?(benjamin)
Assignee | ||
Comment 2•19 years ago
|
||
(Making the summary more understandable)
Summary: Don't build most of the uconv modules when building native uconv → Please don't build most of the uconv modules when building native uconv
Comment 3•19 years ago
|
||
Comment on attachment 216331 [details] [diff] [review]
Patch
I'm not an intl peer, though this looks good in general.
Attachment #216331 -
Flags: review?(benjamin) → review?(jshin1987)
Updated•19 years ago
|
Assignee: nobody → mh
Status: UNCONFIRMED → NEW
Component: Build Config → Internationalization
Ever confirmed: true
Updated•19 years ago
|
Attachment #216331 -
Flags: review?(jshin1987) → review+
Comment 4•17 years ago
|
||
Comment on attachment 216331 [details] [diff] [review]
Patch
This patch is still valid. Requesting approval.
Attachment #216331 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #216331 -
Flags: approval1.9? → approval1.9+
Updated•17 years ago
|
Keywords: checkin-needed
Comment 5•17 years ago
|
||
Thanks for the patch!
Checking in intl/uconv/Makefile.in;
/cvsroot/mozilla/intl/uconv/Makefile.in,v <-- Makefile.in
new revision: 1.23; previous revision: 1.22
done
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
You need to log in
before you can comment on or make changes to this bug.
Description
•