331818 - xpidl crashes when no file name is given on the command line

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mike Hommey [:glandium]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.8.0.1) Gecko/20060313 Debian/1.5.dfsg+1.5.0.1-4 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.8.0.1) Gecko/20060313 Debian/1.5.dfsg+1.5.0.1-4 Firefox/1.5.0.1

Everything is in the summary

Reproducible: Always

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch

- Quit with an error message instead of crashing.
- Don't show the "extra arguments after input file" message when there's neither extra argument not input file.

Comment 2

[Philip Withnall (unavailable)]

Confirmed.

Comment 3

[David Bradley]

We should consolidate the error checking to something like below. It makes it clear what you're doing than the current patch.

    /* Check for invalid command line */
    if (argc > i + 1) {
        fprintf(stderr, "ERROR: extra arguments after input file\n");
    }
    else if (argc == i) {
         fprintf(stderr, "ERROR: no file to process\n");
    }

Comment 4

[Mike Shaver (:shaver emeritus)]

Comment on attachment 216374 [details] [diff] [review]
Patch

sr=shaver

Comment 5

[timeless]

Comment on attachment 216374 [details] [diff] [review]
Patch

mozilla/xpcom/typelib/xpidl/xpidl.c 	1.38