331908 - "Open All in Tabs" does not work when no browser window is open

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

openLinksInTabs has divergent handling for:
- opening folders in tabs
- opening a multiple selection in tabs

... these two should be unified. 

Also, the function is very long/difficult to follow. 

It also needs to handle opening links in tabs when there is no browser window open already.

Comment 1

[Joey Minta]

Attachment: open window and try again

This patch just fixes the part about not being able to open-in-tabs if there's no browser. If we don't find a window via getTopWin, we'll open one, and then once it has loaded, we'll load the links in it.

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 252170 [details] [diff] [review]
open window and try again

I'd rather send reviews of controller.js to mano, who has been very active in this file recently.

as for my two cents, if mano thinks this is the way to go, i think we should leverage OpenBrowserWindow() in browser.js, instead of duplicating the defaultArgs / newWin code.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 252170 [details] [diff] [review]
open window and try again

This is too complex IMO (esp. once we make sure these methods don't open pages into popup windows, no I don't have the bug # handy ;) ). We should rather use the same technique as in http://lxr.mozilla.org/seamonkey/source/browser/components/bookmarks/content/bookmarks.js#869.

Also, the code in browser.js should accept a strings array, this can be filed separately though.

Comment 5

[Mike Connor [:mconnor]]

Will be fixed by bug 175124, assigning to Mano

Comment 6

[Asaf Romano (gone)]

Yup.

Comment 7

[Tracy Walker [:tracy]]

verified with - Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091404 Minefield/3.0a8pre

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv