332002 - Different order of Places between new and imported profiles

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Adam Kowalczyk]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060328 Firefox/2.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060328 Firefox/2.0a1

In the left Places pane, on a new profile, the order is:
Bookmarks Menu
Bookmarks Toolbar
History
Subscriptions

On an imported profile:
History
Bookmarks Menu
Bookmarks Toolbar
Subscriptions

Reproducible: Always

Steps to Reproduce:

Comment 1

[Brett Wilson]

*** Bug 332408 has been marked as a duplicate of this bug. ***

Comment 2

[Brett Wilson]

Marking as dupe of newer bug 333454 (get rid of bookmarks.html) because that is more specific.

The problem is the bookmarks.html was changed to the new format with the places root at the root. It should have been kept in the old format. The normal import/export should be in the old format. The only time there should be the place root defined at the root of bookmarks.html is when it is being initially built.

*** This bug has been marked as a duplicate of 333454 ***

Comment 3

[Brett Wilson]

Bug 333454 was rejected so I'm reopening.

Comment 4

[Brett Wilson]

Actually, the ordering problem doesn't have anything to do with the bookmarks.html format, so I'm changing it back to Adam's title

Comment 5

[Brett Wilson]

Attachment: Patch

The changes to default_places.html are to the branch to bring it in sync with the trunk. The other change prevents reordering of items when they already appear in the hiearchy but are being imported again. We also handle having places be a child of the menu for the purposes of the legacy bookmarks.html format which this is.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 217932 [details] [diff] [review]
Patch

r=[e-mail]

Comment 7

[Brett Wilson]

Attachment: Patch to check in

Since the original patch, some of the features w.r.t. the places root were already put in, and the default bookmarks was cleaned up. This patch is therefore much smaller.

Comment 8

[Brett Wilson]

Fixed on trunk.

Checking in nsBookmarksHTML.cpp;
/cvsroot/mozilla/browser/components/places/src/nsBookmarksHTML.cpp,v  <-- nsBookmarksHTML.cpp
new revision: 1.24; previous revision: 1.23

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv