332036 - Favicons don't get set for pages that are loaded in background tabs

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Brett Wilson]

Apparently the way we hook into the favicon messages doesn't work for background tabs.

Comment 1

[Simon Bünzli]

Attachment: store the favicon also when not loaded for the current tab

Comment 2

[Brett Wilson]

Comment on attachment 216661 [details] [diff] [review]
store the favicon also when not loaded for the current tab

Please fix the indentations for the stuff in the MOZ_PLACES #define (should be out-dented two spaces.

Looks good otherwise.

Comment 3

[Simon Bünzli]

Attachment: indentation fixes

The indentation fix makes it harder to see in the patch which lines really changed. Together with the fix you asked for, I've also made the .getService calls look the same.

Comment 4

[Brett Wilson]

Comment on attachment 216668 [details] [diff] [review]
indentation fixes

Do I need to check in for you or can you do it?

Comment 5

[Simon Bünzli]

I'll have to leave that to you (got no CVS write-access).

Comment 6

[Bryan]

Can we get checkin for this, branch and trunk once approval has been granted?

~B

Comment 7

[Simon Bünzli]

This is Places code and thus not needed on the branch.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.js 	1.651

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv