332045 - toolkit/components/gnome should use the glue

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Benjamin Smedberg]

toolkit/components/gnome should use the frozen string API and the glue

Comment 1

[Benjamin Smedberg]

Attachment: Build components/gnome against the glue, rev. 1

Comment 2

[Darin Fisher]

Comment on attachment 216591 [details] [diff] [review]
Build components/gnome against the glue, rev. 1

>Index: toolkit/components/gnome/nsGConfService.cpp

>+  nsCAutoString key(NS_LITERAL_CSTRING("/desktop/gnome/url-handlers/"));
>+  key.Append(aScheme);
>+  key.Append(NS_LITERAL_CSTRING("/command"));

Personally, I'd just drop the NS_LITERAL_CSTRING calls here.  The
savings of not having to compute string lengths is probably not
significant compared to the cost of initializing and finalizing
nsCStringContainer objects.

Same goes for elsewhere.


>Index: toolkit/components/gnome/nsGnomeVFSService.cpp
...
> NS_IMETHODIMP
> nsGnomeVFSMimeApp::GetSupportedURISchemes(nsIUTF8StringEnumerator** aSchemes)
> {
>   *aSchemes = nsnull;
> 
>+  nsRefPtr<UTF8StringEnumerator> array = new UTF8StringEnumerator();
>   NS_ENSURE_TRUE(array, NS_ERROR_OUT_OF_MEMORY);
> 
>   for (GList *list = mApp->supported_uri_schemes; list; list = list->next) {
>+    if (!array->mStrings.AppendElement(nsDependentCString((char*) list->data))) {

Did you try compiling this without the nsDependentCString(...) bit?
I think it should work because nsCString has a constructor that
takes a |const char *|.  The nsDependentCString doesn't do anything
to avoid a string copy.


>+  nsCAutoString fileExtToUse(NS_LITERAL_CSTRING("."));
>+  fileExtToUse.Append(aExtension);

Again, NS_LITERAL_CSTRING could be dropped here.


r=darin

Comment 3

[Benjamin Smedberg]

Fixed on trunk.

Comment 4

[Benjamin Smedberg]

Wrong bug.

Comment 5

[Benjamin Smedberg]

Really fixed on trunk.