Closed Bug 332072 Opened 15 years ago Closed 15 years ago

Fixup submission cosmetics

Categories

(Core Graveyard :: XForms, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: allan, Assigned: allan)

References

()

Details

(Keywords: fixed1.8.0.4, fixed1.8.1)

Attachments

(1 file)

 
Attached patch PatchSplinter Review
Fix submission header as smaug suggested... purely cosmetics. And no, I am not going to fix the string parameters, etc.
Assignee: aaronr → allan
Status: NEW → ASSIGNED
Attachment #216615 - Flags: review?(smaug)
Comment on attachment 216615 [details] [diff] [review]
Patch

Hmm, now that you're fixing  cosmetics, you could make sure that parameters are in form aParameter

+  NS_HIDDEN_(nsresult) SerializeData(nsIDOMNode *data, nsCString &uri,
+                                     nsIInputStream **, nsCString &contentType);
This looks especially strange
(In reply to comment #2)
> (From update of attachment 216615 [details] [diff] [review] [edit])
> Hmm, now that you're fixing  cosmetics, you could make sure that parameters are
> in form aParameter
> 
> +  NS_HIDDEN_(nsresult) SerializeData(nsIDOMNode *data, nsCString &uri,
> +                                     nsIInputStream **, nsCString
> &contentType);
> This looks especially strange

Please see comment 1 ... 
Attachment #216615 - Flags: review?(smaug) → review+
Attachment #216615 - Flags: review?(doronr)
Attachment #216615 - Flags: review?(doronr) → review+
Checked into trunk
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
Blocks: 332853
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.