The current convention followed by our package file names (implemented via package-name.mk) says the following: http://developer.mozilla.org/en/docs/Package_Filename_Convention#Platform_.5B-special.5D ------- Special is used to distinguish non-default characteristics of the build: 1. GTK2 is the default toolkit on linux platforms. If a GTK binary is built, "-gtk1" is appended to the platform; 2. for distiction to other builds, other non-default build options should be specified there in short but meaningful identifiers, e.g. builds including a patch for the MNG image format should specify -mng, or windows builds compiled with gcc instead of MSVC may specify -gcc here. ------- We're doing that for -gtk1 automatically, but one should be able to easily add in a "special" identifier easily - our usual way for such things is to use env vars.
Created attachment 216630 [details] [diff] [review] add MOZ_PKG_SPECIAL into package name if present Following the style of that file, this patch adds the string in the env var MOZ_PKG_SPECIAL as special part to the package name if present. This way, one can e.g. "export MOZ_PKG_SPECIAL=gcc4" in his shiny new Linux tinderbox and the packages it spits out will have "linux-i686-gcc4" as their "Platform [-special]" part.
For testing, I did I tested with this patch in my SeaMonkey trunk build: cd mozilla/xpinstall/packager; export MOZ_PKG_SPECIAL=gcc4; make results in seamonkey-1.5a.en-US.linux-i686-gcc4.tar.bz2 while cd mozilla/xpinstall/packager; export MOZ_PKG_SPECIAL=; make still results in seamonkey-1.5a.en-US.linux-i686.tar.bz2 So the name stays the same as without the patch when the env var is unset (or empty), and it's correctly added when set :)
Comment on attachment 216630 [details] [diff] [review] add MOZ_PKG_SPECIAL into package name if present It's totally not clear to me where this variable would come from: most of the time I'm opposed to having environment vars affect the build: perhaps we should AC_SUBST this var so that it can be set in mozconfig?
Created attachment 217183 [details] [diff] [review] patch v2: make it possible to set MOZ_PKG_SPECIAL from mozconfig OK, here's a version that makes it possible to set this from mozconfig (at least it works in my patched trunk tree with "MOZ_PKG_SPECIAL=kairo" added to my mozconfig)
Comment on attachment 217183 [details] [diff] [review] patch v2: make it possible to set MOZ_PKG_SPECIAL from mozconfig requesting branch approvals. The fix is trivial and straightforward, and it would be nice to be easily able to e.g. distingiush mac universal binaries from traditional PPC packages in the generated package names (esp. in tinderbox-generated builds)
Checked in on trunk.
landed on 1.8 branch as well :)
Comment on attachment 217183 [details] [diff] [review] patch v2: make it possible to set MOZ_PKG_SPECIAL from mozconfig approved for 1.8.0 branch, a=dveditz for drivers
Checked into 1.8.0 branch.