Closed
Bug 332123
Opened 19 years ago
Closed 19 years ago
nsLocalFileWin::AppendRelativeNativePath broken with multiple path components
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: benjamin, Assigned: jshin1987)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.08 KB,
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
Reported by Lev Serebryakov: If you have an XPCOM component in a subdirectory of the components directory, that component will not be loaded by XPCOM. This is because the component registry stores a relative path to the component location of the form "subdir\component.js", which is passed to nsILocalFile.appendRelativeNativePath. But the windows implementation of this function now ignores the "multipleComponents" argument passed to in and unconditionally rejects multiple components
http://lxr.mozilla.org/mozilla/source/xpcom/io/nsLocalFileWin.cpp#1131
|
Assignee | |
Comment 1•19 years ago
|
||
Sorry for another regression due to another stupid typo. Somehow I used '\' while meaning '/'.
Attachment #216645 -
Flags: superreview?(darin)
Attachment #216645 -
Flags: review?(darin)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 216645 [details] [diff] [review]
patch (one-liner)
no worries. thanks for patching this quickly!
Attachment #216645 -
Flags: superreview?(darin)
Attachment #216645 -
Flags: superreview+
Attachment #216645 -
Flags: review?(darin)
Attachment #216645 -
Flags: review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
thanks for r/sr. patch got landed.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•