Closed Bug 332125 Opened 18 years ago Closed 18 years ago

Better logging of MDG loop errors

Categories

(Core Graveyard :: XForms, enhancement)

Product:
Core Graveyard
Component:
XForms
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: allan, Assigned: allan)

References

(
URL
)

Details

(Keywords: fixed1.8.0.4, fixed1.8.1)

Attachments

(1 file, 2 obsolete files)

Updated to tip
8.90 KB, patch
Details | Diff | Splinter Review 
Right now, it's only possible to see warnings about loops in the MDG if you run a debug build. We should always let the user know if there's a loop error.
Attached patch Patch (obsolete) — — Splinter Review 

        Attachment #216644 -
        Flags: review?(doronr)

    
  
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 216644 [details] [diff] [review]
Patch

It would be neat if we could say what model, but this is better than nothing.

        Attachment #216644 -
        Flags: review?(doronr) → review+

    
    

    
  
Comment on attachment 216644 [details] [diff] [review]
Patch

No, let's do it now. Sorry about the bogus review.

        Attachment #216644 -
        Flags: review+ → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v2 (obsolete)
        — 
          — Splinter Review
      

    


  
Also prints the model.

Beats me why QI'ing from nsIModelElementPrivate to nsIDOMElement does not work, but it does not. Whatever...this saves the QI :)

        Attachment #216644 -
        Attachment is obsolete: true

        Attachment #217020 -
        Flags: review?(doronr)

        Attachment #217020 -
        Flags: review?(doronr) → review+

    
  

        Attachment #217020 -
        Flags: review?(Olli.Pettay)

        Attachment #217020 -
        Flags: review?(Olli.Pettay) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Updated to tip
        — 
          — Splinter Review
      

    


  

        Attachment #217020 -
        Attachment is obsolete: true

    
    

    
  
Checked into trunk
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch

    
  
Blocks: 332853

    
  
Keywords: fixed1.8.0.3, 
          
            fixed1.8.1

    
  
Whiteboard: xf-to-branch
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: