atomservice should provide UTF8 accessors

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
XPCOM
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

Trunk
mozilla1.9alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Atomservice currently only provides wchar* accessors, which is inefficient in many cases (especially since atoms are stored as utf8 internally).
(Assignee)

Comment 1

12 years ago
Created attachment 216654 [details] [diff] [review]
Add UTF8 accessors, rev. 1
Attachment #216654 - Flags: review?(darin)

Comment 2

12 years ago
Comment on attachment 216654 [details] [diff] [review]
Add UTF8 accessors, rev. 1

I think I'd prefer getAtomUTF8 and getPermanentAtomUTF8 because it is not the atom that is UTF8, it is the parameter that is UTF8.  See for example nsIAtom::EqualsUTF8.

r=darin with that change
Attachment #216654 - Flags: review?(darin) → review+
(Assignee)

Comment 3

12 years ago
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.