Closed
Bug 332135
Opened 19 years ago
Closed 19 years ago
atomservice should provide UTF8 accessors
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
|
2.13 KB,
patch
|
darin.moz
:
review+
|
Details | Diff | Splinter Review |
Atomservice currently only provides wchar* accessors, which is inefficient in many cases (especially since atoms are stored as utf8 internally).
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #216654 -
Flags: review?(darin)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 216654 [details] [diff] [review]
Add UTF8 accessors, rev. 1
I think I'd prefer getAtomUTF8 and getPermanentAtomUTF8 because it is not the atom that is UTF8, it is the parameter that is UTF8. See for example nsIAtom::EqualsUTF8.
r=darin with that change
Attachment #216654 -
Flags: review?(darin) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•