332192 - The DOM Inspector's maximized state is not remembered

Status: VERIFIED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Simon Bünzli]

... due to using persist="... maximized" instead of persist="... sizemode".

Comment 1

[Simon Bünzli]

Attachment: replace persist="maximized" with persist="sizemode"

Although I'm not sure whether sidebar.xul needs persisting size attributes at all.

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 216707 [details] [diff] [review]
replace persist="maximized" with persist="sizemode"

Can the sidebar stuff really be maximized?  r=caillon

Comment 3

[timeless]

do you need someone to check this in for you?

Comment 4

[Simon Bünzli]

Indeed. Please go ahead.

Comment 5

[Bryan]

Can we please get this checked in?

~B

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/extensions/inspector/resources/content/object.xul 	1.4
mozilla/extensions/inspector/resources/content/inspector.xul 	1.11
mozilla/extensions/inspector/resources/content/sidebar.xul 	1.5

Comment 7

[Bryan]

I'm assuming you're going to check this into branch as well?

~B

Comment 8

[:Gavin Sharp [email: [e-mail]]]

No, it doesn't have approval.

Comment 9

[Simon Bünzli]

Comment on attachment 216707 [details] [diff] [review]
replace persist="maximized" with persist="sizemode"

BTW: It'd be nice if there was any way more appropriate for approval1.8.1 than to target the next SeaMonkey release.

Comment 10

[Bryan]

(In reply to comment #9)
> (From update of attachment 216707 [details] [diff] [review] [edit])
> BTW: It'd be nice if there was any way more appropriate for approval1.8.1 than
> to target the next SeaMonkey release.

Simon,

Can you also request approval for 1.8.1 branch?

~B

Comment 11

[Bryan]

Can this please be checked into the 1.8.1 branch?

~B

Comment 12

[Bryan]

Can someone ask mconnor for branch approval.  I'm unable to get on IRC at the moment and have emailed him but haven't received response.

~B

Comment 13

[Mike Connor [:mconnor]]

I'm not the right person to set approval-seamonkey1.1a.  If this component should be covered under the generic 1.8.1 flags, please file a bug to tweak that.

Comment 14

[Bryan]

(In reply to comment #13)
> I'm not the right person to set approval-seamonkey1.1a.  If this component
> should be covered under the generic 1.8.1 flags, please file a bug to tweak
> that.

Mike,
I believe Simons intention was to get approval for FF branch 1.8.1 and not Seamonkey as that is what he stated to me.  Can you approve this for the branch or do I actually have to file a bug to get the ability to set the FF approval flag and then set that once that is completed and wait however long that takes?

~B

Comment 15

[:Gavin Sharp [email: [e-mail]]]

mozilla/extensions/inspector/resources/content/sidebar.xul 	1.4.74.1
mozilla/extensions/inspector/resources/content/object.xul 	1.3.78.1
mozilla/extensions/inspector/resources/content/inspector.xul 	1.10.4.1