Closed
Bug 332192
Opened 19 years ago
Closed 19 years ago
The DOM Inspector's maximized state is not remembered
Categories
(Other Applications :: DOM Inspector, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.8final
People
(Reporter: zeniko, Assigned: zeniko)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
4.27 KB,
patch
|
caillon
:
review+
mconnor
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
... due to using persist="... maximized" instead of persist="... sizemode".
Assignee | ||
Comment 1•19 years ago
|
||
Although I'm not sure whether sidebar.xul needs persisting size attributes at all.
Attachment #216707 -
Flags: review?(caillon)
Comment 2•19 years ago
|
||
Comment on attachment 216707 [details] [diff] [review]
replace persist="maximized" with persist="sizemode"
Can the sidebar stuff really be maximized? r=caillon
Attachment #216707 -
Flags: review?(caillon) → review+
Assignee | ||
Comment 4•19 years ago
|
||
Indeed. Please go ahead.
Status: NEW → ASSIGNED
Whiteboard: [checkin needed]
Updated•19 years ago
|
Assignee: dom-inspector → zeniko
Status: ASSIGNED → NEW
Comment 6•19 years ago
|
||
mozilla/extensions/inspector/resources/content/object.xul 1.4
mozilla/extensions/inspector/resources/content/inspector.xul 1.11
mozilla/extensions/inspector/resources/content/sidebar.xul 1.5
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha
Version: unspecified → Trunk
Comment 8•19 years ago
|
||
No, it doesn't have approval.
Assignee | ||
Comment 9•19 years ago
|
||
Comment on attachment 216707 [details] [diff] [review]
replace persist="maximized" with persist="sizemode"
BTW: It'd be nice if there was any way more appropriate for approval1.8.1 than to target the next SeaMonkey release.
Attachment #216707 -
Flags: approval-seamonkey1.1a?
Comment 10•19 years ago
|
||
(In reply to comment #9)
> (From update of attachment 216707 [details] [diff] [review] [edit])
> BTW: It'd be nice if there was any way more appropriate for approval1.8.1 than
> to target the next SeaMonkey release.
Simon,
Can you also request approval for 1.8.1 branch?
~B
Comment 12•18 years ago
|
||
Can someone ask mconnor for branch approval. I'm unable to get on IRC at the moment and have emailed him but haven't received response.
~B
Comment 13•18 years ago
|
||
I'm not the right person to set approval-seamonkey1.1a. If this component should be covered under the generic 1.8.1 flags, please file a bug to tweak that.
Comment 14•18 years ago
|
||
(In reply to comment #13)
> I'm not the right person to set approval-seamonkey1.1a. If this component
> should be covered under the generic 1.8.1 flags, please file a bug to tweak
> that.
Mike,
I believe Simons intention was to get approval for FF branch 1.8.1 and not Seamonkey as that is what he stated to me. Can you approve this for the branch or do I actually have to file a bug to get the ability to set the FF approval flag and then set that once that is completed and wait however long that takes?
~B
Assignee | ||
Updated•18 years ago
|
Attachment #216707 -
Flags: approval-seamonkey1.1a? → approval1.8.1?
Updated•18 years ago
|
Attachment #216707 -
Flags: approval1.8.1? → approval-branch-1.8.1?(mconnor)
Updated•18 years ago
|
Attachment #216707 -
Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed]
Comment 15•18 years ago
|
||
mozilla/extensions/inspector/resources/content/sidebar.xul 1.4.74.1
mozilla/extensions/inspector/resources/content/object.xul 1.3.78.1
mozilla/extensions/inspector/resources/content/inspector.xul 1.10.4.1
Flags: blocking1.8.1?
Keywords: fixed1.8.1
Whiteboard: [checkin needed]
Target Milestone: mozilla1.9alpha → mozilla1.8final
Version: Trunk → 1.8 Branch
Assignee | ||
Updated•18 years ago
|
Status: RESOLVED → VERIFIED
Updated•17 years ago
|
QA Contact: timeless → dom-inspector
You need to log in
before you can comment on or make changes to this bug.
Description
•