Closed Bug 332192 Opened 15 years ago Closed 15 years ago

The DOM Inspector's maximized state is not remembered

Categories

(Other Applications :: DOM Inspector, defect)

1.8 Branch
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.8final

People

(Reporter: zeniko, Assigned: zeniko)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

... due to using persist="... maximized" instead of persist="... sizemode".
Although I'm not sure whether sidebar.xul needs persisting size attributes at all.
Attachment #216707 - Flags: review?(caillon)
Comment on attachment 216707 [details] [diff] [review]
replace persist="maximized" with persist="sizemode"

Can the sidebar stuff really be maximized?  r=caillon
Attachment #216707 - Flags: review?(caillon) → review+
do you need someone to check this in for you?
Indeed. Please go ahead.
Status: NEW → ASSIGNED
Whiteboard: [checkin needed]
Can we please get this checked in?

~B
Assignee: dom-inspector → zeniko
Status: ASSIGNED → NEW
mozilla/extensions/inspector/resources/content/object.xul 	1.4
mozilla/extensions/inspector/resources/content/inspector.xul 	1.11
mozilla/extensions/inspector/resources/content/sidebar.xul 	1.5
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha
Version: unspecified → Trunk
I'm assuming you're going to check this into branch as well?

~B
No, it doesn't have approval.
Comment on attachment 216707 [details] [diff] [review]
replace persist="maximized" with persist="sizemode"

BTW: It'd be nice if there was any way more appropriate for approval1.8.1 than to target the next SeaMonkey release.
Attachment #216707 - Flags: approval-seamonkey1.1a?
(In reply to comment #9)
> (From update of attachment 216707 [details] [diff] [review] [edit])
> BTW: It'd be nice if there was any way more appropriate for approval1.8.1 than
> to target the next SeaMonkey release.

Simon,

Can you also request approval for 1.8.1 branch?

~B

Can this please be checked into the 1.8.1 branch?

~B
Flags: blocking1.8.1?
Can someone ask mconnor for branch approval.  I'm unable to get on IRC at the moment and have emailed him but haven't received response.

~B
I'm not the right person to set approval-seamonkey1.1a.  If this component should be covered under the generic 1.8.1 flags, please file a bug to tweak that.
(In reply to comment #13)
> I'm not the right person to set approval-seamonkey1.1a.  If this component
> should be covered under the generic 1.8.1 flags, please file a bug to tweak
> that.

Mike,
I believe Simons intention was to get approval for FF branch 1.8.1 and not Seamonkey as that is what he stated to me.  Can you approve this for the branch or do I actually have to file a bug to get the ability to set the FF approval flag and then set that once that is completed and wait however long that takes?

~B
Attachment #216707 - Flags: approval-seamonkey1.1a? → approval1.8.1?
Attachment #216707 - Flags: approval1.8.1? → approval-branch-1.8.1?(mconnor)
Attachment #216707 - Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
Whiteboard: [checkin needed]
mozilla/extensions/inspector/resources/content/sidebar.xul 	1.4.74.1
mozilla/extensions/inspector/resources/content/object.xul 	1.3.78.1
mozilla/extensions/inspector/resources/content/inspector.xul 	1.10.4.1
Flags: blocking1.8.1?
Keywords: fixed1.8.1
Whiteboard: [checkin needed]
Target Milestone: mozilla1.9alpha → mozilla1.8final
Version: Trunk → 1.8 Branch
Status: RESOLVED → VERIFIED
QA Contact: timeless → dom-inspector
You need to log in before you can comment on or make changes to this bug.