332201 - the same keys conflict in places' context menu

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[changdong.cui]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060330 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060330 Firefox/1.6a1

two menu items  in Places'  context menu share the same accesskey.

Reproducible: Always

Steps to Reproduce:
1.Launch firefox and expand Bookmarks menu.
2.Select Organize Bookmarks menu to open the bookmark manage window
3. Push the mouse right button, two items in the context menu share a same accesskey "S". Two items are " New Separator" and "Sort * by Name". 

Actual Results:  
if you press Ctrl+S, it switches between two items .

Expected Results:  
two items should have the different accesskey

Comment 1

[changdong.cui]

Attachment: Screenshot of the contex menu

Comment 2

[Mark Romero]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060329 Firefox/1.6a1

Confirmed.

Comment 3

[changdong.cui]

Attachment: patch

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 217413 [details] [diff] [review]
patch

See my comment in the other bug I just review-ed for more info.

IMO, it's not a good idea to add a new "command" (which means something in terms of the capabilities of the places system) just to support divergent accesskeys. I think it'd be better if we took the accesskey attribute off the offending <command> and put it on each of the UI elements that uses the command.

Comment 5

[changdong.cui]

(In reply to comment #4)
> (From update of attachment 217413 [details] [diff] [review] [edit])
> See my comment in the other bug I just review-ed for more info.
> 
> IMO, it's not a good idea to add a new "command" (which means something in
> terms of the capabilities of the places system) just to support divergent
> accesskeys. I think it'd be better if we took the accesskey attribute off the
> offending <command> and put it on each of the UI elements that uses the
> command.
> 
you mean only change the conflict things, anyway ,if we change one UI element like that ,should we change all UI element to conform the same style ? 

Comment 6

[changdong.cui]

Attachment: Same as bug331414, as ben suggested.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 217998 [details] [diff] [review]
Same as bug331414, as ben suggested.

r=[e-mail]

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

bringing in so I can check this in. 

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

bringing in so I can check this in. 

Comment 10

[changdong.cui]

(In reply to comment #9)
> bringing in so I can check this in. 
> 

sorry , i do not know the meaning of "bringing in" exactly.

Comment 11

[changdong.cui]

(In reply to comment #9)
> bringing in so I can check this in. 
> 

Hi,ben can you help me to check this patch in? 
thanks!

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Attachment: checked in

Checked in branch and trunk.

mozilla/browser/locales/en-US/chrome/browser/places/places.dtd	1.12
mozilla/browser/components/places/content/commands.inc		1.20
mozilla/browser/components/places/content/context.inc		1.11
mozilla/browser/components/places/content/places.xul		1.45

mozilla/browser/locales/en-US/chrome/browser/places/places.dtd	1.1.2.13 
mozilla/browser/components/places/content/places.xul		1.28.2.19
mozilla/browser/components/places/content/commands.inc		1.4.2.18
mozilla/browser/components/places/content/context.inc		1.1.2.12

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv