undefined @step should be "1" for xsd:integer

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
12 years ago
a year ago

People

(Reporter: Allan Beaufour, Assigned: Allan Beaufour)

Tracking

({fixed1.8.0.5, fixed1.8.1})

Trunk
fixed1.8.0.5, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

4.06 KB, patch
Doron Rosenberg (IBM)
: review+
smaug
: review+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
If the range is bound to xsd:integer and no step-size is given, it should be set to "1" to avoid floats. There is also a bug in that it sets it to float during incremental iirc.
(Assignee)

Updated

11 years ago
Assignee: aaronr → xforms
(Assignee)

Comment 1

11 years ago
Created attachment 223701 [details] [diff] [review]
Patch

Sets step size to 1 if bound to an xsd:integer. Also adjusts the values to the step size, if the range is incremental.

The patch is really "bad" in the sense that it specifically checks for xsd:integer.... we need a schemavalidator.isDerivedFrom(type, "xsd:integer") function. Or do we have that already?
Assignee: xforms → allan
Status: NEW → ASSIGNED
Attachment #223701 - Flags: review?(doronr)

Comment 2

11 years ago
Comment on attachment 223701 [details] [diff] [review]
Patch

From what I understand, Aaron was working on an "isDerivedFrom" that would live in XForms, we should know more once he comes back next week.
Attachment #223701 - Flags: review?(doronr) → review+
(Assignee)

Comment 3

11 years ago
(In reply to comment #2)
> (From update of attachment 223701 [details] [diff] [review] [edit])
> From what I understand, Aaron was working on an "isDerivedFrom" that would live
> in XForms, we should know more once he comes back next week.

Ok, I'll file a follow up bug (and assign it to him :-) )
(Assignee)

Updated

11 years ago
Attachment #223701 - Flags: review?(Olli.Pettay)
(Assignee)

Updated

11 years ago
Blocks: 339660

Updated

11 years ago
Attachment #223701 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Comment 4

11 years ago
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.0.5
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.1
(Assignee)

Updated

11 years ago
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.