332227 - SVGLoad doesn't have a capture or bubble phase, only @target

Status: RESOLVED WORKSFORME

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Filing this while I remember.

In SVG, many (if not all - I can't be bothered to check right now) SVG elements should be sent an SVGLoad event. There is no capture or bubble phase for these events for performance reasons. Only the target's listeners should be activated. We might be able to quite easily implement this by setting aVisitor.mCanHandle to PR_FALSE in nsSVGElement::PreHandleEvent (smaug you are my hero!) - except that the node that does this isn't included in the event chain. Maybe we could set mCanHandle if a check for |this == target| fails. In fact, yeah, that could work I think.

I've not checked whether smaug's event dispatch rewrite plays happily with a single item event target chain, but I should think so.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: testcase

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Yes, it plays nicely with only one item in the chain :)

I still wonder whether it is a bug in svg spec that there shouldn't be
even the capture phase or whether that is something the spec authors really want.

Comment 3

[Robert Longson [:longsonr]]

WFM now. I imagine all the html5 parser rework fixed it.