"View HTML Source" in Midas demo no longer works

VERIFIED FIXED in mozilla1.9alpha1

Status

()

P3
normal
VERIFIED FIXED
13 years ago
12 years ago

People

(Reporter: uriber, Assigned: peterv)

Tracking

({regression})

Trunk
mozilla1.9alpha1
PowerPC
Mac OS X
regression
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8.1 -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

13 years ago
Checking the "View HTML Source" checkbox in the Midas demo page (http://www.mozilla.org/editor/midasdemo/) no longer works.
I get the following error in the JS Console:

Error: uncaught exception: [Exception... "Access to property denied"  code: "1010" nsresult: "0x805303f2 (NS_ERROR_DOM_PROP_ACCESS_DENIED)"  location: "http://www.mozilla.org/editor/midasdemo/ Line: 388"]

The relevant JS source code is:
html = document.getElementById('edit').contentWindow.document.importNode(html,false);

This regressed on the trunk between 2005-09-24 and 2005-09-25, so I suspect bug  296230 is involved.
(Reporter)

Comment 1

13 years ago
Actually, it could just as well (and perhaps even more likely) be bug 27382.
(Reporter)

Comment 2

13 years ago
Peter, any insight on this?
(Assignee)

Comment 3

13 years ago
We should probably change the security check in importNode, or wait for bug 332182 to be fixed.
Assignee: general → peterv
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Target Milestone: --- → mozilla1.9alpha
Depends on: 332182
Flags: blocking1.9a1?
Fixed by checkin for bug 332182.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Flags: blocking1.9a1?
Resolution: --- → FIXED
(Reporter)

Comment 5

12 years ago
This is broken on the branch as well, but bug 332182 was only fixed on trunk.
Can we live with this in 1.8.1?
Flags: blocking1.8.1?
181drivers say: the patch in bug 332182 looks pretty significant. We'd consider an isolated fix if we can get a solid set of regression tests that show that the fix is safe. Based on the low number of dupes and the fact that this never showed up as a potential blocker before makes us wonder what the impact is beyond this specific demo page ...
Flags: blocking1.8.1? → blocking1.8.1-
Verified FIXED using build:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070620 Minefield/3.0a6pre

with the steps in comment 0; also, no JS errors thrown in the Error Console.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.