332238 - "View HTML Source" in Midas demo no longer works

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Uri Bernstein]

Checking the "View HTML Source" checkbox in the Midas demo page (http://www.mozilla.org/editor/midasdemo/) no longer works.
I get the following error in the JS Console:

Error: uncaught exception: [Exception... "Access to property denied"  code: "1010" nsresult: "0x805303f2 (NS_ERROR_DOM_PROP_ACCESS_DENIED)"  location: "http://www.mozilla.org/editor/midasdemo/ Line: 388"]

The relevant JS source code is:
html = document.getElementById('edit').contentWindow.document.importNode(html,false);

This regressed on the trunk between 2005-09-24 and 2005-09-25, so I suspect bug  296230 is involved.

Comment 1

[Uri Bernstein]

Actually, it could just as well (and perhaps even more likely) be bug 27382.

Comment 2

[Uri Bernstein]

Peter, any insight on this?

Comment 3

[Peter Van der Beken [:peterv]]

We should probably change the security check in importNode, or wait for bug 332182 to be fixed.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixed by checkin for bug 332182.

Comment 5

[Uri Bernstein]

This is broken on the branch as well, but bug 332182 was only fixed on trunk.
Can we live with this in 1.8.1?

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

181drivers say: the patch in bug 332182 looks pretty significant. We'd consider an isolated fix if we can get a solid set of regression tests that show that the fix is safe. Based on the low number of dupes and the fact that this never showed up as a potential blocker before makes us wonder what the impact is beyond this specific demo page ...

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070620 Minefield/3.0a6pre

with the steps in comment 0; also, no JS errors thrown in the Error Console.