332397 - build error when "--disable-xpinstall" is specified: *** No rule to make target `-lmozreg_s', needed by `libxpcom_compat.dylib'. Stop.

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Hiro]

The following errors come out by build of Camino.

Reproducible: Always

c++ -o nsSpecialSystemDirectory.o -c  -DMOZILLA_INTERNAL_API -DOSTYPE=\"Darwin7.9.0\" -DOSARCH=\"Darwin\" -DBUILD_ID=2006040105 -D_IMPL_NS_COM_OBSOLETE -I.. -I./../io  -I../../dist/include/xpcom -I../../dist/include/string -I../../dist/include/macmorefiles -I../../dist/include   -I../../dist/include/xpcom_obsolete -I../../dist/include/nspr    -I../../dist/sdk/include    -fPIC   -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -Os -pipe -mcpu=7400 -nostdinc -nostdinc++ -I/Developer/SDKs/MacOSX10.2.8.sdk/usr/include/gcc/darwin/3.3/c++ -I/Developer/SDKs/MacOSX10.2.8.sdk/usr/include/gcc/darwin/3.3/c++/ppc-darwin -I/Developer/SDKs/MacOSX10.2.8.sdk/usr/include/gcc/darwin/3.3/c++/backward -isystem /Developer/SDKs/MacOSX10.2.8.sdk/usr/include/gcc/darwin/3.3 -isystem /Developer/SDKs/MacOSX10.2.8.sdk/usr/include -F/Developer/SDKs/MacOSX10.2.8.sdk/System/Library/Frameworks -F/Developer/SDKs/MacOSX10.2.8.sdk/Library/Frameworks -fpascal-strings -no-cpp-precomp -fno-common -fshort-wchar -I/Developer/SDKs/MacOSX10.2.8.sdk/Developer/Headers/FlatCarbon -pipe  -DNDEBUG -DTRIMMED -Os -pipe -mcpu=7400 -I/Developer/SDKs/MacOSX10.2.8.sdk/Developer/Headers/FlatCarbon   -DMOZILLA_CLIENT -include ../../mozilla-config.h -Wp,-MD,.deps/nsSpecialSystemDirectory.pp nsSpecialSystemDirectory.cpp
nsSpecialSystemDirectory.cpp:120: warning: `PRBool 
   DeleteSystemDirKeys(nsHashKey*, void*, void*)' defined but not used
make[4]: *** No rule to make target `-lmozreg_s', needed by `libxpcom_compat.dylib'.  Stop.
make[4]: Leaving directory `/Users/sek/Documents/mozilla-current/camino/mozilla/xpcom/obsolete'
make[3]: *** [libs_tier_2] Error 2

.mozconfig of Camino build
ac_add_options --enable-application=macbrowser
ac_add_options --enable-default-toolkit=cocoa
ac_add_options --disable-tests
ac_add_options --enable-crypto
ac_add_options --disable-accessibility
ac_add_options --disable-jsd
ac_add_options --disable-xpinstall
ac_add_options --disable-debug
ac_add_options --enable-optimize="-Os -pipe -mcpu=7400"
ac_add_options --enable-strip
ac_add_options --disable-logging
ac_add_options --disable-dtd-debug
ac_add_options --enable-prebinding
ac_add_options --disable-logrefcnt
ac_add_options --disable-profilesharing
ac_add_options --enable-single-profile
ac_add_options --with-macos-sdk=/Developer/SDKs/MacOSX10.2.8.sdk
ac_add_options --enable-canvas
ac_add_options --enable-svg
ac_add_options --disable-v1-string-abi


There is no problem in build of Firefox.

.mozconfig of Firefox build
ac_add_options --enable-application=browser
ac_add_options --enable-strip
ac_add_options --enable-crypto
ac_add_options --enable-optimize="-Os -pipe -mcpu=7400"
ac_add_options --enable-prebinding
ac_add_options --disable-tests
ac_add_options --disable-debug
ac_add_options --disable-dtd-debug
ac_add_options --disable-jsd
ac_add_options --disable-ldap
ac_add_options --disable-logging
ac_add_options --disable-mailnews
ac_add_options --disable-composer
ac_add_options --enable-plaintext-editor-only

ac_add_options --disable-negotiateauth
ac_add_options --disable-webservices
ac_add_options --disable-gnomevfs
ac_add_options --enable-extensions=cookie,inspector,permissions

ac_add_options --disable-logrefcnt
ac_add_options --disable-profilesharing
ac_add_options --disable-mathml
ac_add_options --disable-accessibility
ac_add_options --disable-installer
ac_add_options --enable-single-profile
ac_add_options --disable-v1-string-abi
ac_add_options --enable-svg
ac_add_options --with-macos-sdk=/Developer/SDKs/MacOSX10.2.8.sdk


Mac OS X 10.3.9

Comment 1

[Hiro]

There was no problem in .mozconfig of the following.

. $topsrcdir/camino/config/mozconfig

ac_add_options --enable-strip
ac_add_options --enable-optimize="-Os -pipe -mcpu=7400"
ac_add_options --enable-prebinding
ac_add_options --with-macos-sdk=/Developer/SDKs/MacOSX10.2.8.sdk

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Looks like mento checked in a fix for this: http://tinyurl.com/msmby

Comment 3

[Mark Mentovai]

This looks different from the bug I fixed earlier today.

This was probably caused by --disable-xpinstall.

Comment 4

[Hiro]

Build succeeded when "--disable-xpinstall" was removed from .mozconfig. 

Comment 5

[Håkan Waara]

Does building with --disable-xpinstall work now?   Hiro, wanna re-try?

Comment 6

[Hiro]

The error still occurs as follows. 

.mozconfig
. $topsrcdir/camino/config/mozconfig

ac_add_options --enable-strip
ac_add_options --enable-optimize="-Os -pipe -mcpu=7400"
ac_add_options --enable-prebinding
ac_add_options --disable-xpinstall
ac_add_options --with-macos-sdk=/Developer/SDKs/MacOSX10.2.8.sdk

===
build log:

c++ -o nsSpecialSystemDirectory.o -c  -DMOZILLA_INTERNAL_API -DOSTYPE=\"Darwin7.9.0\" -DOSARCH=\"Darwin\" -DBUILD_ID=0000000000 -D_IMPL_NS_COM_OBSOLETE -I.. -I./../io  -I../../dist/include/xpcom -I../../dist/include/string -I../../dist/include/macmorefiles -I../../dist/include   -I../../dist/include/xpcom_obsolete -I../../dist/include/nspr    -I../../dist/sdk/include    -fPIC   -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -nostdinc -nostdinc++ -I/Developer/SDKs/MacOSX10.2.8.sdk/usr/include/gcc/darwin/3.3/c++ -I/Developer/SDKs/MacOSX10.2.8.sdk/usr/include/gcc/darwin/3.3/c++/ppc-darwin -I/Developer/SDKs/MacOSX10.2.8.sdk/usr/include/gcc/darwin/3.3/c++/backward -isystem /Developer/SDKs/MacOSX10.2.8.sdk/usr/include/gcc/darwin/3.3 -isystem /Developer/SDKs/MacOSX10.2.8.sdk/usr/include -F/Developer/SDKs/MacOSX10.2.8.sdk/System/Library/Frameworks -F/Developer/SDKs/MacOSX10.2.8.sdk/Library/Frameworks -fpascal-strings -no-cpp-precomp -fno-common -fshort-wchar -I/Developer/SDKs/MacOSX10.2.8.sdk/Developer/Headers/FlatCarbon -pipe  -DNDEBUG -DTRIMMED -Os -pipe -mcpu=7400 -I/Developer/SDKs/MacOSX10.2.8.sdk/Developer/Headers/FlatCarbon   -DMOZILLA_CLIENT -include ../../mozilla-config.h -Wp,-MD,.deps/nsSpecialSystemDirectory.pp nsSpecialSystemDirectory.cpp
nsSpecialSystemDirectory.cpp:120: warning: `PRBool 
   DeleteSystemDirKeys(nsHashKey*, void*, void*)' defined but not used
rm -f libxpcom_compat.dylib
c++  -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -nostdinc -nostdinc++ -I/Developer/SDKs/MacOSX10.2.8.sdk/usr/include/gcc/darwin/3.3/c++ -I/Developer/SDKs/MacOSX10.2.8.sdk/usr/include/gcc/darwin/3.3/c++/ppc-darwin -I/Developer/SDKs/MacOSX10.2.8.sdk/usr/include/gcc/darwin/3.3/c++/backward -isystem /Developer/SDKs/MacOSX10.2.8.sdk/usr/include/gcc/darwin/3.3 -isystem /Developer/SDKs/MacOSX10.2.8.sdk/usr/include -F/Developer/SDKs/MacOSX10.2.8.sdk/System/Library/Frameworks -F/Developer/SDKs/MacOSX10.2.8.sdk/Library/Frameworks -fpascal-strings -no-cpp-precomp -fno-common -fshort-wchar -I/Developer/SDKs/MacOSX10.2.8.sdk/Developer/Headers/FlatCarbon -pipe  -DNDEBUG -DTRIMMED -Os -pipe -mcpu=7400 -I/Developer/SDKs/MacOSX10.2.8.sdk/Developer/Headers/FlatCarbon -fPIC  -o libxpcom_compat.dylib  nsFileSpec.o nsFileStream.o nsIFileStream.o nsFileSpecImpl.o nsSpecialSystemDirectory.o      -Wl,-dead_strip -dynamiclib -install_name @executable_path/libxpcom_compat.dylib -compatibility_version 1 -current_version 1 ../../modules/libreg/src/libmozreg_s.a -L../../dist/bin -lxpcom -lxpcom_core -L../../dist/bin -L../../dist/lib -lplds4 -lplc4 -lnspr4 -L/Developer/SDKs/MacOSX10.2.8.sdk/usr/lib/gcc/darwin -L/Developer/SDKs/MacOSX10.2.8.sdk/usr/lib/gcc/darwin/3.3 -L/Developer/SDKs/MacOSX10.2.8.sdk/usr/lib  -framework Carbon -L/Developer/SDKs/MacOSX10.2.8.sdk/usr/lib/gcc/darwin -L/Developer/SDKs/MacOSX10.2.8.sdk/usr/lib/gcc/darwin/3.3 -L/Developer/SDKs/MacOSX10.2.8.sdk/usr/lib    
c++: ../../modules/libreg/src/libmozreg_s.a: No such file or directory
make[4]: *** [libxpcom_compat.dylib] Error 1
make[3]: *** [libs_tier_2] Error 2
make[2]: *** [tier_2] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Bug 332384 should fix this for the trunk.

Comment 8

[Eiichi]

Build succeeded with --disable-xpinstall on the branch.
I didn't test on the trunk, though.

1. Mac OS X Version: 10.4.10 (Build 8R2218)
2. Darwin Kernel Version: 8.10.1
3. Apple GCC Version: 4.0.1
4. XCode Tools Version: 2.4.1

ac_add_options --enable-macos-target=10.4
ac_add_options --with-macos-sdk=/Developer/SDKs/MacOSX10.4u.sd
ac_add_options --disable-xpinstall

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Do we actually want to add --disable-xpinstall (or the confvars.sh equivalent, rather) to the trunk (to match the branch change from bug 408959)?

I assume this bug as reported is fixed on the trunk due to the deps (profileshareing and xpcom_obsolete) being off on trunk, but I haven't checked yet.

Comment 10

[Mark Mentovai]

That would be MOZ_XPINSTALL= in confvars.sh, and yes.

Comment 11

[Mark Mentovai]

xpcom-obsolete and xpinstall are no longer built on the 1.8 branch as of bug 408959.  xpcom-obsolete is no longer used in Camino.app on the trunk or 1.8 branch as of bug 332384.  Per comment 9 and 10, we should take xpinstall out of the trunk build here.  This should prevent libmozreg from building - we don't use it, and we will stop trying to link it in bug 409599.

Comment 12

[Mark Mentovai]

Attachment: Always disable xpinstall on the trunk

This patch depends on bug 409599.

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 294434 [details] [diff] [review]
Always disable xpinstall on the trunk

Tested static opt and non-static debug; all is well, as expected.

Comment 14

[Mark Mentovai]

Checked in on the trunk.