332493 - Folders disappear when dragged

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Ria Klaassen (not reading all bugmail)]

Steps to reproduce:
- Start Firefox with the default set of bookmarks 
- Open Places
- Drag "Firefox and Mozilla Links" into Bookmarks Toolbar or Bookmarks Menu
- Drag it back if you still can find it (it maybe immediately lost if you drag it into the menu)
Result: also after a restart "Firefox and Mozilla Links" is gone.

Also other folders on the left side show a faulty behaviour.
It appears to me that Firefox does not quite know where exactly the location of the folder is.
This bug may be related to Bug 332220 but I don't know if it is quite a dupe.

Comment 1

[Ria Klaassen (not reading all bugmail)]

I've made a testcase.
- Import the set of bookmarks I'll attach
- Open Places and drag all the folders from menu to bookmarks toolbar
- Then start dragging them back. Some of them may not appear in the folder and you may experience hangs of Places. The hangs sometimes end when you close Places but sometimes the whole application doesn't react anymore. 
- Then move them all again to bookmarks toolbar. You'll see more and more of the folders disappear and some lost folders reappear magically.
You may end up with 5 folders instead of 9.

Comment 2

[Ria Klaassen (not reading all bugmail)]

Attachment: bookmarks

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

What piece of UI am I using here? Can you provide excrutiating detail?

Comment 4

[Brett Wilson]

Attachment: Disallow bad negative indices from the bookmarks service

This patch throws an exception if a negative index is passed in for the location of an item. -1 is still accepted to mean "append". Now, these operations that caused the folder to disappear will assert, which should make finding the frontend bug easier.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 217325 [details] [diff] [review]
Disallow bad negative indices from the bookmarks service

r=[e-mail]

Comment 6

[Brett Wilson]

The bookmarks service patch is on branch and trunk. I'm closing this bug because the folders don't disappear anymore. I filed bug 332873 for fixing the invalid indices problem when dragging over folders.

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv