Last Comment Bug 332588 - Dropping link in single line input opens multiline input
: Dropping link in single line input opens multiline input
Product: Other Applications
Classification: Client Software
Component: ChatZilla (show other bugs)
: Trunk
: All All
-- normal (vote)
: ---
Assigned To: :Gijs
: Samuel Sieb
Depends on:
  Show dependency treegraph
Reported: 2006-04-03 09:40 PDT by Rob Marshall [tH]
Modified: 2006-12-08 04:36 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Hacky patch (1.43 KB, patch)
2006-11-20 08:36 PST, :Gijs
bugzilla-mozilla-20000923: review+
Details | Diff | Splinter Review

Description User image Rob Marshall [tH] 2006-04-03 09:40:23 PDT
text/x-moz-url data (URL\nTitle) dropped into the single line input box used to just lose the title, which was okay. The drop handler (bug 307774) handles both lines as-is, which is annoying.

It should either discard the title, or arrange the URL and title on one line to avoid opening the multiline box.
Comment 1 User image :Gijs 2006-11-20 08:36:01 PST
Created attachment 246029 [details] [diff] [review]
Hacky patch

I don't like this patch very much. I don't think we can do anything better, because the transferrable is sucky that way and will not tell us it also supports x-moz-url. That is, if you ask it to enumerate all the flavours, it magically forgot about x-moz-url, at least in my testing. In other words, we're kind of screwed, hence the hack. Fortunately this also seems to work just fine :-)
Comment 2 User image James Ross 2006-11-22 06:16:47 PST
Waaa, that's horrible. What happens if you do data.getTransferData on the URL type? Does that give you anything?
Comment 3 User image James Ross 2006-11-27 07:16:31 PST
Comment on attachment 246029 [details] [diff] [review]
Hacky patch

>Index: mozilla/extensions/irc/xul/content/handlers.js
>+    var lines ="\n");
>+    var m = lines[0].match(client.linkRE);

Please add a giant XXX comment here about the transferable not having the special URL type and that this is a hack.

r=silver with that added.
Comment 4 User image :Gijs 2006-11-28 13:51:08 PST
    // XXX part of what follows is a very ugly hack to make links (with a title)
    // not open the multiline box. We 'should' be able to ask the transferable
    // what flavours it supports, but testing showed that by the time we can ask
    // for that info, it's forgotten about everything apart from text/unicode.

Checking in mozilla/extensions/irc/xul/content/handlers.js;
/cvsroot/mozilla/extensions/irc/xul/content/handlers.js,v  <--  handlers.js
new revision: 1.140; previous revision: 1.139

Note You need to log in before you can comment on or make changes to this bug.