Expose livemark annotation names for use in JavaScript

RESOLVED WONTFIX

Status

()

Firefox
Bookmarks & History
--
enhancement
RESOLVED WONTFIX
12 years ago
8 years ago

People

(Reporter: Joe Hughes, Assigned: Joe Hughes)

Tracking

2.0 Branch
Firefox 2 alpha2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Currently, the annotation strings used by the live bookmarks service are defined in constants in nsLivemarkService.h.  However, any JS users that want to refer to those annotations would need to redefine those strings to use them.  If we expose those annotation strings through nsILivemarkService, we can avoid having those strings defined in multiple places.
(Assignee)

Comment 1

12 years ago
Created attachment 217076 [details] [diff] [review]
Patch that adds read-only attributes for the annotation strings
Attachment #217076 - Flags: review?(annie.sullivan)
(Assignee)

Updated

12 years ago
Target Milestone: --- → Firefox 2 alpha2
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED

Comment 2

12 years ago
I do not think we should do this. I think that the fact that the livemark service uses annotations is an implementation detail that should be hidden. Any information needed by people dealing with livemark features should be exposed through the livemark service API so we can change the annotations in the future. This is bug 332049.

Comment 3

12 years ago
Comment on attachment 217076 [details] [diff] [review]
Patch that adds read-only attributes for the annotation strings


> NS_IMETHODIMP
>+nsLivemarkService::GetFeedURIAnno(nsAString &aAnno)
>+{
>+  aAnno = NS_LITERAL_STRING(LMANNO_FEEDURI);
>+  return NS_OK;
>+}

Use aAnno.AssignLiteral(LMANNO_FEEDURI);
Same for GetSiteURIAnno(), GetFeedExpirationAnno(), and GetItemSourceFeedURIAnno().
Attachment #217076 - Flags: review?(annie.sullivan) → review-
(Assignee)

Comment 4

12 years ago
I agree with Brett's comment, so I'm going to WONTFIX this case and add methods to the annotation as described in bug 332617.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → WONTFIX
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.