Last Comment Bug 332633 - remove duplicate header files in nss/cmd/sslsample
: remove duplicate header files in nss/cmd/sslsample
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Tools (show other bugs)
: 3.11
: All All
: P2 normal (vote)
: 3.12
Assigned To: Nelson Bolyard (seldom reads bugmail)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-04-03 17:54 PDT by Nelson Bolyard (seldom reads bugmail)
Modified: 2006-04-13 00:58 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
remove duplicate files, change manifests (checked in) (43.05 KB, patch)
2006-04-03 17:59 PDT, Nelson Bolyard (seldom reads bugmail)
julien.pierre: review+
Details | Diff | Splinter Review

Description Nelson Bolyard (seldom reads bugmail) 2006-04-03 17:54:48 PDT
NSS's header files that define the error strings are in nss/cmd/lib
but they are also duplicated in nss/cmd/sslsample. 
They should not be duplicated there.

Patch forthcoming.
Comment 1 Nelson Bolyard (seldom reads bugmail) 2006-04-03 17:59:03 PDT
Created attachment 217096 [details] [diff] [review]
remove duplicate files, change manifests (checked in)
Comment 2 Julien Pierre 2006-04-03 18:14:38 PDT
Comment on attachment 217096 [details] [diff] [review]
remove duplicate files, change manifests (checked in)

r+, but REQUIRES = dbm should be removed from client.mn/server.mn rather than just commented .
Comment 3 Nelson Bolyard (seldom reads bugmail) 2006-04-03 18:58:35 PDT
Checking in lib/manifest.mn;     new revision: 1.10; previous revision: 1.9
Checking in SSLsample/client.mn; new revision: 1.4; previous revision: 1.3
Checking in SSLsample/server.mn; new revision: 1.4; previous revision: 1.3
Removing SSLsample/NSPRerrs.h;   new revision: delete; previous revision: 1.2
Removing SSLsample/SECerrs.h;    new revision: delete; previous revision: 1.2
Removing SSLsample/SSLerrs.h;    new revision: delete; previous revision: 1.3
Comment 4 Nelson Bolyard (seldom reads bugmail) 2006-04-03 19:01:40 PDT
I only fixed this on the trunk.
If you think I should fix this on the 3.11 branch also,
please reopen, change the target to 3.11.1 and
request second review.  
Comment 5 Nelson Bolyard (seldom reads bugmail) 2006-04-13 00:58:36 PDT
Comment on attachment 217096 [details] [diff] [review]
remove duplicate files, change manifests (checked in)

Checked in on branch
Removing SSLsample/NSPRerrs.h; new revision: delete; previous revision: 1.2
Removing SSLsample/SECerrs.h;  new revision: delete; previous revision: 1.2
Removing SSLsample/SSLerrs.h;  new revision: delete; previous revision: 1.2.28.1
Checking in SSLsample/client.mn; new revision: 1.3.28.1; previous revision: 1.3
Checking in SSLsample/server.mn; new revision: 1.3.28.1; previous revision: 1.3
Checking in lib/manifest.mn;     new revision: 1.9.28.1; previous revision: 1.9

Note You need to log in before you can comment on or make changes to this bug.