Closed
Bug 332633
Opened 19 years ago
Closed 19 years ago
remove duplicate header files in nss/cmd/sslsample
Categories
(NSS :: Tools, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.12
People
(Reporter: nelson, Assigned: nelson)
Details
Attachments
(1 file)
43.05 KB,
patch
|
julien.pierre
:
review+
|
Details | Diff | Splinter Review |
NSS's header files that define the error strings are in nss/cmd/lib
but they are also duplicated in nss/cmd/sslsample.
They should not be duplicated there.
Patch forthcoming.
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #217096 -
Flags: review?(julien.pierre.bugs)
Comment 2•19 years ago
|
||
Comment on attachment 217096 [details] [diff] [review]
remove duplicate files, change manifests (checked in)
r+, but REQUIRES = dbm should be removed from client.mn/server.mn rather than just commented .
Attachment #217096 -
Flags: review?(julien.pierre.bugs) → review+
Assignee | ||
Comment 3•19 years ago
|
||
Checking in lib/manifest.mn; new revision: 1.10; previous revision: 1.9
Checking in SSLsample/client.mn; new revision: 1.4; previous revision: 1.3
Checking in SSLsample/server.mn; new revision: 1.4; previous revision: 1.3
Removing SSLsample/NSPRerrs.h; new revision: delete; previous revision: 1.2
Removing SSLsample/SECerrs.h; new revision: delete; previous revision: 1.2
Removing SSLsample/SSLerrs.h; new revision: delete; previous revision: 1.3
Status: NEW → RESOLVED
Closed: 19 years ago
Priority: -- → P2
Resolution: --- → FIXED
Target Milestone: --- → 3.11.1
Assignee | ||
Comment 4•19 years ago
|
||
I only fixed this on the trunk.
If you think I should fix this on the 3.11 branch also,
please reopen, change the target to 3.11.1 and
request second review.
Target Milestone: 3.11.1 → 3.12
Assignee | ||
Comment 5•19 years ago
|
||
Comment on attachment 217096 [details] [diff] [review]
remove duplicate files, change manifests (checked in)
Checked in on branch
Removing SSLsample/NSPRerrs.h; new revision: delete; previous revision: 1.2
Removing SSLsample/SECerrs.h; new revision: delete; previous revision: 1.2
Removing SSLsample/SSLerrs.h; new revision: delete; previous revision: 1.2.28.1
Checking in SSLsample/client.mn; new revision: 1.3.28.1; previous revision: 1.3
Checking in SSLsample/server.mn; new revision: 1.3.28.1; previous revision: 1.3
Checking in lib/manifest.mn; new revision: 1.9.28.1; previous revision: 1.9
Attachment #217096 -
Attachment description: remove duplicate files, change manifests → remove duplicate files, change manifests (checked in)
You need to log in
before you can comment on or make changes to this bug.
Description
•