Open
Bug 332640
Opened 19 years ago
Updated 2 years ago
screen object doesn't work if docshell has no content viewer
Categories
(Core :: DOM: Core & HTML, defect, P5)
Core
DOM: Core & HTML
Tracking
()
NEW
People
(Reporter: bryner, Unassigned)
References
Details
Attachments
(1 file)
1.57 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
bzbarsky
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
Currently, the DOMScreen object returns 0 for the screen dimensions of a newly-created window (that is, one where nothing has forced the about:blank content viewer to be created). I've seen problems in the past where trying to force earlier creation of the blank viewer regressed performance, so I'd like to instead change nsScreen so that it doesn't rely on the content viewer. It's a fairly straightforward change.
Reporter | ||
Comment 1•19 years ago
|
||
Attachment #217110 -
Flags: superreview?(jst)
Attachment #217110 -
Flags: review?(jst)
Reporter | ||
Comment 2•19 years ago
|
||
Comment on attachment 217110 [details] [diff] [review]
patch
Boris, your r+sr would be great here too.
Attachment #217110 -
Flags: superreview?(jst) → superreview?(bzbarsky)
Comment 3•19 years ago
|
||
Comment on attachment 217110 [details] [diff] [review]
patch
Seems reasonable, but we may have to revisit this when we stop giving all docshells a widget.... Then again, we'll need to revisit all sorts of code then.
Attachment #217110 -
Flags: superreview?(bzbarsky) → superreview+
Reporter | ||
Comment 4•19 years ago
|
||
checked in on trunk
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•19 years ago
|
||
Comment on attachment 217110 [details] [diff] [review]
patch
I'd like to get this in on the branch as well, for bug 329871. Should be pretty safe, right?
Attachment #217110 -
Flags: approval-branch-1.8.1?(bzbarsky)
Comment 6•19 years ago
|
||
Comment on attachment 217110 [details] [diff] [review]
patch
Yeah, probably...
Attachment #217110 -
Flags: review?(jst)
Attachment #217110 -
Flags: review+
Attachment #217110 -
Flags: approval-branch-1.8.1?(bzbarsky)
Attachment #217110 -
Flags: approval-branch-1.8.1+
Comment 8•19 years ago
|
||
This patch caused bug 333051 (breaking context menus, XUL menus on non-Cairo builds)
Depends on: 333051
Reporter | ||
Comment 9•19 years ago
|
||
backed out to fix bug 333051
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Updated•18 years ago
|
Assignee: bryner → general
Status: REOPENED → NEW
Updated•15 years ago
|
Assignee: general → nobody
QA Contact: ian → general
Comment 11•7 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046
Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.
If you have questions, please contact :mdaly.
Priority: -- → P5
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•