Open Bug 332640 Opened 19 years ago Updated 2 years ago

screen object doesn't work if docshell has no content viewer

Categories

(Core :: DOM: Core & HTML, defect, P5)

defect

Tracking

()

People

(Reporter: bryner, Unassigned)

References

Details

Attachments

(1 file)

Currently, the DOMScreen object returns 0 for the screen dimensions of a newly-created window (that is, one where nothing has forced the about:blank content viewer to be created). I've seen problems in the past where trying to force earlier creation of the blank viewer regressed performance, so I'd like to instead change nsScreen so that it doesn't rely on the content viewer. It's a fairly straightforward change.
Attached patch patchSplinter Review
Attachment #217110 - Flags: superreview?(jst)
Attachment #217110 - Flags: review?(jst)
Comment on attachment 217110 [details] [diff] [review] patch Boris, your r+sr would be great here too.
Attachment #217110 - Flags: superreview?(jst) → superreview?(bzbarsky)
Comment on attachment 217110 [details] [diff] [review] patch Seems reasonable, but we may have to revisit this when we stop giving all docshells a widget.... Then again, we'll need to revisit all sorts of code then.
Attachment #217110 - Flags: superreview?(bzbarsky) → superreview+
checked in on trunk
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 217110 [details] [diff] [review] patch I'd like to get this in on the branch as well, for bug 329871. Should be pretty safe, right?
Attachment #217110 - Flags: approval-branch-1.8.1?(bzbarsky)
Comment on attachment 217110 [details] [diff] [review] patch Yeah, probably...
Attachment #217110 - Flags: review?(jst)
Attachment #217110 - Flags: review+
Attachment #217110 - Flags: approval-branch-1.8.1?(bzbarsky)
Attachment #217110 - Flags: approval-branch-1.8.1+
checked in on the branch
Keywords: fixed1.8.1
This patch caused bug 333051 (breaking context menus, XUL menus on non-Cairo builds)
Depends on: 333051
backed out to fix bug 333051
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
No longer fixed on branch
Keywords: fixed1.8.1
No longer blocks: 329871
Assignee: bryner → general
Status: REOPENED → NEW
Assignee: general → nobody
QA Contact: ian → general
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046 Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5. If you have questions, please contact :mdaly.
Priority: -- → P5
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: