332811 - Backspace in readonly input triggers history.back() (part 2)

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Martijn Wargers (dead)]

Spin-off from bug 332345.

Currently, you can see the caret when a readonly text input has focus.
This can be confusing for the user, thinking he can erase any existing text, by pressing the backspace key. 
He would then be surprised to see he is going back in history instead.

So maybe just disable the backspace key for readonly inputs now?

Comment 1

[Martijn Wargers (dead)]

Attachment: patch

This is the patch that would change that behavior.

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 217281 [details] [diff] [review]
patch

Seems reasonable.
Please put the '{' on a separate line like the surrounding code.
r=mats with that.

Comment 3

[Martijn Wargers (dead)]

Attachment: patch

> (From update of attachment 217281 [details] [diff] [review] [edit])
> Seems reasonable.
> Please put the '{' on a separate line like the surrounding code.
> r=mats with that.

Ok, done that.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 237320 [details] [diff] [review]
patch

Looks good!

Comment 5

[Martijn Wargers (dead)]

Checking in nsEditorEventListeners.cpp;
/cvsroot/mozilla/editor/libeditor/text/nsEditorEventListeners.cpp,v  <--  nsEdit
orEventListeners.cpp
new revision: 1.241; previous revision: 1.240
done

Checked into trunk.

Comment 6

[[e-mail]]

It's weird that backspace is handled by a key event but delete is a command...