332939 - [regression] Printing fails: once past the print set up page, the progress box sits idle

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[philippe (part-time)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060405 Camino/1.2+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060405 Camino/1.2+

The print dialogue box loads correctly, but once pressing 'preview', 'print to PDF' or 'Print', a progress bar pops up, but sits idle. Hitting 'cancel' has no effect.
Only solution is to force quit the browser.

Reproducible: Always

Steps to Reproduce:
1. Load page
2. File menu > Print, window comes up correctly
3. 'Print', or 'preview' or select a PDF option

Actual Results:  
progress window, idle. Hitting cancel has no effect.

Expected Results:  
Print the document

Comment 1

[philippe (part-time)]

Happens both with Camino and Firefox.
OS X 10.4.6

Comment 2

[ender.mb]

And here I thought this was just a fluke .. I'm seeing this as well on Camino trunk back to (at least) april 1st. This should probably be Core, not Firefox.

Comment 3

[philippe (part-time)]

regression range:
For Camino
2006032700 works
2006040200 doesn't work

Firefox
Yes - Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060329 Firefox/1.6a1
No - Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060330 Firefox/1.6a1

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Based on the Fx regression range http://tinyurl.com/fdlm5 bug 331415 looks like the obvious culprit.  

Isn't this the kind of thing that smoketests should catch, or are there none?

Comment 5

[Mark Mentovai]

Eli, what do you think?  Do you have a Mac to look at this on?

Comment 6

[Eli Friedman]

Possibly a dup of Bug 332806, even though this doesn't appear to be completely crashing; I would have posted a separate patch earlier except I have the patch to bug 332927 in my tree.  The basic issue for the crash is at http://lxr.mozilla.org/seamonkey/source/layout/printing/nsPrintEngine.cpp#740; to patch, replace "mPresContext->DeviceContext()" with "mDeviceContext".

I don't have a Mac to look at this on, so it would be nice if you could check and see if that fixes the problem.

Reassigning to myself to deal with it, since I almost certainly caused it, even if it's not what I think it is.

Comment 7

[philippe (part-time)]

(In reply to comment #6)
> Possibly a dup of Bug 332806, even though this doesn't appear to be completely
> crashing; I would have posted a separate patch earlier except I have the patch
> to bug 332927 in my tree.  The basic issue for the crash is at
> http://lxr.mozilla.org/seamonkey/source/layout/printing/nsPrintEngine.cpp#740;
> to patch, replace "mPresContext->DeviceContext()" with "mDeviceContext".

I've just finished building Camino with this mod.
It doesn't change anything.

Comment 8

[Eli Friedman]

Hmm.  Hard for me to debug without a Mac.  The most likely problem is that some function is failing silently.  I think the most helpful thing would be for someone to try stepping through nsPrintEngine::Print() with a debugger, and look for functions returning failure codes.  I didn't touch any platform-specific code, so it probably has to do with some difference in the platform-specific print code.

Comment 9

[Mark Mentovai]

Attachment: Patch

The native print session was being dealloced.  I don't really know why this wasn't a problem in the past, but I'm not about to read through a 125kB diff to figure out what changed that triggered this bug.

Comment 10

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 217865 [details] [diff] [review]
Patch

sr=pink

Comment 11

[Mark Mentovai]

Fixed!

Comment 12

[philippe (part-time)]

(In reply to comment #11)
> Fixed!
> 

I'm not sure...
That works fine with Firefox: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060411 Firefox/3.0a1

But with Camino (2006041200 (1.2+), I get this error message:
'An unknown error occurred while printing.'