332975 - Left margin on RTL list item pushes the list marker (bullet) to the right

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Uri Bernstein]

This was originally reported in comments on bug 262195.

If an RTL list item has a left margin (specified e.g. using margin-left or -moz-margin-end), the list marker (bullet) on the right side of the item is pushed to the right by an amount equal to the width of the left margin.

attachment 169516 [details] and attachment 191005 [details] (from bug 262195) show this problem. I'll attach a smaller testcase soon.

Comment 1

[Uri Bernstein]

Attachment: testcase

This is a small testcase (using -moz-margin-end), demonstrating the difference between RTL (top, buggy), and LTR (bottom, OK).

Comment 2

[Uri Bernstein]

The patch on bug 332360 indeed would fix this as well.

Comment 3

[Uri Bernstein]

Fixed by the fix for bug 332360. Verified with:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a3pre) Gecko/20070308 Minefield/3.0a3pre

Comment 4

[Uri Bernstein]

Attachment: reftest

Not sure what the review procedure is for reftests - but since this is my first one, it's probably a good idea for someone to have a look at it anyway.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 258125 [details] [diff] [review]
reftest

This one looks fine, except for the "No newline at end of file" (Unix convention uses newline as a line terminator, not a line separator).  But you could also throw in some padding to test that too.  And perhaps even add the LTR equivalent?

(Either way, feel free to check in.)

Comment 6

[Uri Bernstein]

Reftest checked in, with extra newline and an item with padding.

Comment 7

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).