333031 - Uninitialized value when entering a new bug and an alias is given

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

post_bug.cgi: Use of uninitialized value in concatenation (.) or string at Bugzilla/Util.pm line 73

This is because Bugzilla::Bug::ValidateBugAlias($alias, $curr_id) contains the line:
if (detaint_natural($curr_id))

When creating a new bug, $curr_id is undefined (the bug has no ID yet) and so it tries to detaint an undefined value.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Frédéric Buclin]

Note that this message appears only when an alias is specified when creating a new bug. If you give none, no warning is displayed.

Comment 3

[Teemu Mannermaa (:wicked)]

Comment on attachment 217456 [details] [diff] [review]
patch, v1

Yep, this fixes the error.

Comment 4

[Teemu Mannermaa (:wicked)]

Patch seems to apply to 2.20 branch too. Even thought the default enter bug template doesn't include an alias field, post_bug.cgi contains code to handle a specified alias parameter so fixing this is good thing to do. People can specify the alias parameter manually or even change template to contain the alias field.

Comment 5

[Frédéric Buclin]

tip:

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.116; previous revision: 1.115
done

2.22rc1:

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.104.2.2; previous revision: 1.104.2.1
done

2.20.1:

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.81.2.5; previous revision: 1.81.2.4
done