select1 initialized by instance data on form load has wrong size

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
11 years ago
10 months ago

People

(Reporter: Brad Clements, Assigned: smaug)

Tracking

({fixed1.8.0.5, fixed1.8.1})

Trunk
x86
Windows XP
fixed1.8.0.5, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(3 attachments)

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1

A select1 element whose items are loaded from an itemset, and that has
instance data selecting a matching item in that set, has the wrong width
when the form is loaded.

The only way to get the correct width is to use setvalue to set the instance data to null. A subsequent setvalue can be used to re-select the correct value.

Reproducible: Always

Steps to Reproduce:
1. Load referenced url or the attached demonstration file.
2. Note that in section #2 the selects have the wrong width


Actual Results:  
The select1 elements are too narrow. Almost as if their size is determined by the instance data, and not by the itemset choices.

Expected Results:  
The proper width should be used to reflect the actual choices.

I am using xforms 0.4 extension. Note that section 3 of the demonstration file shows using setvalue as a work-around for this problem.

However I play to use these selects in a repeat, so setvalue isn't a realistic workaround.
(Reporter)

Comment 1

11 years ago
Created attachment 217474 [details]
Demonstrates sizing bug
(Assignee)

Comment 2

11 years ago
Created attachment 217689 [details] [diff] [review]
proposed patch

Need to refresh the width of the select1 in few more places.
Assignee: aaronr → Olli.Pettay
Status: UNCONFIRMED → ASSIGNED
Attachment #217689 - Flags: review?(aaronr)
(Assignee)

Updated

11 years ago
Attachment #217689 - Flags: review?(allan)

Updated

11 years ago
Attachment #217689 - Flags: review?(allan) → review+

Updated

11 years ago
Attachment #217689 - Flags: review?(aaronr) → review+
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
(Reporter)

Comment 3

11 years ago
Created attachment 217885 [details]
select1 resizing is not correct inside repeats

This attachment was tested against 0.5RC (2006-4-09). When adding a new repeat template via "add" button, the 2nd filtered select1 in the first template ends up either with the wrong width, and/or no selected choice.
(Reporter)

Comment 4

11 years ago
Please disregard most recent attachment. I have opened #333464 instead.

Updated

11 years ago
Keywords: fixed1.8.1

Updated

11 years ago
Keywords: fixed1.8.0.5

Updated

11 years ago
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.