333118 - Mingw build failure, linking error in nsSound.cpp

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Martijn Wargers (dead)]

(cc-ing you Hans-Andreas, hoping you won't mind)
I'm getting this build error:

H_ -DMOZILLA_CLIENT /cygdrive/c/mozilla/mozilla/widget/src/build/nsWinWidgetFact
ory.cpp
c:/mozilla/mozilla/widget/src/build/nsWinWidgetFactory.cpp:75: warning: `
   nsresult nsNativeThemeWinConstructor(nsISupports*, const nsIID&, void**)'
   defined but not used
rm -f gkwidget.dll
/cygdrive/c/mozilla/mozilla/build/cygwin-wrapper g++ -mno-cygwin -shared -o gkwi
dget.dll  nsWinWidgetFactory.o   widget.res -mwindows -Wl,--enable-runtime-pseud
o-reloc         -Wl,--whole-archive ../../../dist/lib/libwidget_windows.a ../../
../dist/lib/libxpwidgets_s.a  -Wl,--no-whole-archive -L../../../dist/bin -L../..
/../dist/lib -lgkgfx -lthebes -L../../../dist/lib -lxpcom -lxpcom_core -L../../.
./dist/bin -L../../../dist/lib -lnspr4 -lplc4 -lplds4 ../../../dist/lib/libunich
arutil_s.a   -lm  -luuid -lole32 -loleaut32 -lwinspool -lcomctl32 -lcomdlg32 -ls
hell32 -lgdi32 -limm32
../../../dist/lib/libwidget_windows.a(nsSound.o)(.text+0x5ad): In function `ZN7n
sSound14PurgeLastSoundEv':
c:/mozilla/mozilla/widget/src/windows/nsSound.cpp:72: undefined reference to `Pl
aySoundA@12'
../../../dist/lib/libwidget_windows.a(nsSound.o)(.text+0xadc): In function `ZN7n
sSound16OnStreamCompleteEP15nsIStreamLoaderP11nsISupportsjjPKh':
c:/mozilla/mozilla/widget/src/windows/nsSound.cpp:128: undefined reference to `P
laySoundA@12'
../../../dist/lib/libwidget_windows.a(nsSound.o)(.text+0xca0): In function `ZN7n
sSound4InitEv':
c:/mozilla/mozilla/widget/src/windows/nsSound.cpp:158: undefined reference to `P
laySoundA@12'
../../../dist/lib/libwidget_windows.a(nsSound.o)(.text+0xd50): In function `ZN7n
sSound15PlaySystemSoundERK18nsAString_internal':
c:/mozilla/mozilla/widget/src/windows/nsSound.cpp:169: undefined reference to `P
laySoundA@12'
../../../dist/lib/libwidget_windows.a(nsSound.o)(.text+0xdae):c:/mozilla/mozilla
/widget/src/windows/nsSound.cpp:174: undefined reference to `PlaySoundA@12'
make[3]: *** [gkwidget.dll] Error 1
make[3]: Leaving directory `/cygdrive/c/mozilla/mozilla/widget/src/build'
make[2]: *** [libs] Error 2
make[2]: Leaving directory `/cygdrive/c/mozilla/mozilla/widget/src'
make[1]: *** [libs] Error 2
make[1]: Leaving directory `/cygdrive/c/mozilla/mozilla/widget'
make: *** [all] Error 2

C:\mozilla\mozilla\widget>

Comment 1

[Martijn Wargers (dead)]

Attachment: patch

This fixes it for me, not sure if it is any good.
After that I finally get no build errors anymore.

Comment 2

[Masatoshi Kimura [:emk]]

WINCE doesn't use nsSound.cpp (Cc'ing dougt to make sure).
You should add winmm in "ifneq ($(OS_ARCH), WINCE)" part.

Also, don't forget static build (I don't know whether mingw supports static build. If it doesn't, please disregard this).
Firefox: browser/app/Makefile.in
Thunderbird: mail/app/Makefile.in
Sunbird: calendar/sunbird/app/Makefile.in

Comment 3

[Martijn Wargers (dead)]

Attachment: patch

Ok, this is how Masatoshi said it should be.

I don't know if mingw supports static builds. (I don't even know what it is)

Comment 4

[cls]

Comment on attachment 217563 [details] [diff] [review]
patch

Static mingw builds (tb, at least) are broken at the moment.

Comment 5

[cls]

Checked in with the fixes for bug 333941.