333177 - Update canvas internal interfaces and optimize

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This patch optimizes the internal canvas interfaces to allow us to use platform-native surfaces where we can, for some performance speedups.  It also fixes the internal interfaces in such a way that we can support contexts defined outside of layout (e.g. via extensions).

It also fixes a few 2d canvas bugs.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: let RetreiveNativeGraphicData return a real void*

This turns nsIRenderingContext's RetreiveNativeGraphicData into returning a real void*, instead of a PRUint32 -- we were stuffing a pointer into it in in all platforms that used it, which had the potential of breaking badly on any 64-bit builds.

This should go for both trunk and branch.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: let RetreiveNativeGraphicData return a real void*

Er, real patch; previous one was missing a fix to nsObjectFrame.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: canvas interface rework and optimization

This is the actual canvas patch, against the 1.8 branch.  This can go onto the trunk, but the trunk canvas code will be replaced with a rewritten version shortly -- I think I can shoehorn this in if we want it to bake for a few days there.

Comment 4

[Mike Shaver (:shaver emeritus)]

I really want this in Firefox2!

Comment 5

[Mike Shaver (:shaver emeritus)]

From conversation with vlad, the plan:

- land this on trunk and merge
- prepare 1.8 patch from that code, including toDataURL

Note: need more info about image encoder dependencies.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: trunk canvas patch

This is a trunk version of the improvements, that merges the new work with the existing image encoder and security checks on the trunk.  After this gets checked in, I'll merge it all (new stuff + image encoders + security checks) to the branch.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This landed on the trunk; the 1.8 version of this is 333613.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Clearing blocking 1.8.1 request as per comment 7.