333192 - Inconsistent type handling in XML parser and XML PI

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

In the nsXMLStylesheetPI::GetStyleSheetInfo we have:

225   // If we get here we assume that we're loading a css file, so set the
226   // type to 'text/css'
227   aType.AssignLiteral("text/css");

which happens whenever there is no type attr or more precisely when the type attr has an empty type.

On the other hand, nsXMLContentSink::HandleProcessingInstruction assumes that the type returned by nsParserUtils::GetQuotedAttributeValue is what it needs to work with (doesn't SplitMimeType), and only compares it to "text/css", not to the empty string.

The result is that when loading http://dump.testsuite.org/2006/alternate-stylesheet-api/003.xht I get:

###!!! ASSERTION: Why do we still have our old sheet?: '!sameNode', file ../../../mozilla/layout/style/nsCSSLoader.cpp, line 1162

Peter, do you want to fix this, or should I?

Comment 1

[Boris Zbarsky [:bzbarsky]]

fixed as part of patch for bug 84582