333201 - Uninstalling Firefox no longer works

Status: RESOLVED WORKSFORME

(Firefox :: Installer, defect)

Description

[Bill Gianopoulos [:WG9s]]

With recent trunk builds, the windows uninstaller merely removes Firefox from the add/remove programs list.  It fails to uninstall the application.

The uninstaller worked fine with:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060327 Firefox/1.6a1 ID:2006032706

but fails with:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060328 Firefox/1.6a1 ID:2006032806

and subsequent builds.

I suspect the checkin for bug 214889.

Comment 1

[pal-moz]

same with Cairo Build.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060407 Firefox/3.0a1 ID:2006040704 [cairo]

Comment 2

[Jesse Ruderman]

Do you see the error message in bug 329237 when this happens?

Comment 3

[Bill Gianopoulos [:WG9s]]

(In reply to comment #2)
> Do you see the error message in bug 329237 when this happens?
> 
o.  This is completely separate from bug 329237.  This is happening with Pacifica builds which are not VC8, as well as with my own builds using VC7.  I get no error popup.  Also with bug 329237, if I recall correctly after you dismiss the error popup the application actually does get uninstalled correctly, but I could be mis-remembering.

Comment 4

[pal-moz]

(In reply to comment #2)
> Do you see the error message in bug 329237 when this happens?
> 

no error message.

Comment 5

[pal-moz]

I can uninstall 04-10 [cairo].
but short-cut are still there.

Comment 6

[pal-moz]

can not again.
no error message.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060411 Firefox/3.0a1 ID:2006041105 [cairo]

Comment 7

[Minh Tran-Le]

this looks like a generic uninstaller bug as the Thunderbird is also broken the same way as the uninstall process does not remove any files.

I have also notice that compared to previous working version the file:
{Minefield,Thunderbird}\uninstall\install_wizard1.log

Is missing the entries for all the installed files and directories.

Comment 8

[Robert Strong (they/them - no direct email)]

This should now be fixed since the patch in bug 349551 landed a few days ago. Could you please verify and resolve duplicate of bug 349551 if it is indeed fixed? Thanks

Comment 9

[Bill Gianopoulos [:WG9s]]

The main issue in this bu was fixed quite some time ago, I think  by the change to the NSIS installer.  The original issue was that after uninstalling Firefox, the application was still there and could still be launched and executed.

The remaining issue had been that after the uninstall, the Application folder still existed and some folders and files remained.

I just did an install of the latest branch nightly, launched the application, exited and then did and uninstall.  The entire application folder was removed by the uninstall, so I would say this is now completely fixed.

Comment 10

[Robert Strong (they/them - no direct email)]

Reolving wfm